-
Notifications
You must be signed in to change notification settings - Fork 807
Add 1.36 docs team to website-milestone-maintainers, release-team-docs #6095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add 1.36 docs team to website-milestone-maintainers, release-team-docs #6095
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sayanchowdhury The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
6bb83a8 to
72efa01
Compare
dipesh-rawat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
@sayanchowdhury It looks like there’s a merge conflict with the latest changes on main. Could you rebase your branch against the most recent main when you get a chance? |
Signed-off-by: Sayan Chowdhury <sayan.chowdhury2012@gmail.com>
Signed-off-by: Sayan Chowdhury <sayan.chowdhury2012@gmail.com>
72efa01 to
0246273
Compare
|
@dipesh-rawat Thanks for the review! I've rebased the PR now. Can you please re-review? |
dipesh-rawat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This PR adds 1.36 docs team shadows to the appropriate groups i.e website-milestone-maintainers, release-team-docs.
/cc @katcosgrove @rytswd