-
Notifications
You must be signed in to change notification settings - Fork 569
Increase Reporter extensibility #3291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Increase Reporter extensibility #3291
Conversation
|
Welcome @tylerFowler! |
Hi @tylerFowler. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tylerFowler The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Extra context: I'm creating CL2 tests fully programmatically, I'm skipping the |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This change exposes the SubstepResult struct in order to make
test.Reporter
a fully extensible interface. Currently the only out-of-the-box Reporter implementation invokes its ownReportTestStepFinish
method, which does expose this data, but seemingly only to itself (it probably shouldn't be in the main interface for this reason). It relies on a package-private method fromReportTestStep
to fill out this data, and the default Executor only invokes that top level method – this prevents users from implementing custom reporters with any level of test-step visibility.The only way to access this newly public substep data is via the
StepResult.GetAllResults
method which is already mutex protected so simply exposing this seems safe. To that end only getter methods are added to ensure data mutation is limited.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: