Skip to content

Conversation

@serathius
Copy link
Contributor

/kind cleanup

/assign @mborsz

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 15, 2026
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 15, 2026
@mborsz
Copy link
Member

mborsz commented Jan 15, 2026

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mborsz, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2026
@serathius
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2026
@serathius
Copy link
Contributor Author

serathius commented Jan 27, 2026

This time I double checked symlinks to avoid repeat of #3791

find . -print0 | xargs -0 file | grep link
./testing/huge-service/statefulset.yaml:                                                                           symbolic link to ../load/modules/reconcile-objects/statefulset.yaml
./testing/huge-service/simple-deployment.yaml:                                                                     symbolic link to ../load/modules/scheduler-throughput/simple-deployment.yaml
./testing/huge-service/statefulset_service.yaml:                                                                   symbolic link to ../load/modules/reconcile-objects/statefulset_service.yaml
./testing/huge-service/service.yaml:                                                                               symbolic link to ../load/modules/services/service.yaml

Broken version:

find . -print0 | xargs -0 file | grep link
./clusterloader2/testing/huge-service/statefulset.yaml:                                                                                             symbolic link to ../load/modules/reconcile-objects/statefulset.yaml
./clusterloader2/testing/huge-service/simple-deployment.yaml:                                                                                       broken symbolic link to ../load/simple-deployment.yaml
./clusterloader2/testing/huge-service/statefulset_service.yaml:                                                                                     symbolic link to ../load/modules/reconcile-objects/statefulset_service.yaml
./clusterloader2/testing/huge-service/service.yaml:                                                                                                 broken symbolic link to ../load/service.yaml

@serathius
Copy link
Contributor Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants