Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Rendertron usage since it is deprecated #2911

Merged
merged 2 commits into from
Feb 16, 2023

Conversation

ramrodo
Copy link
Member

@ramrodo ramrodo commented Feb 14, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PRs removes Rendertron since it is deprecated.

With this removal, the krel testgridshot tool will no longer take screenshots of the TestGrid boards at adding the GitHub comment to the release cut issue. Also, it will no longer upload any screenshot to the GCS bucket.

We need this removal since every time we run krel testgridshot and it tries to get the screenshot, the process fails and does not publish any GitHub comment throwing this error:

$ krel testgridshot
INFO Starting krel testgrishot...                 
INFO Sending GET request to https://testgrid.k8s.io/sig-release-master-blocking/summary 
INFO Sending GET request to https://testgrid.k8s.io/sig-release-master-informing/summary 
INFO rendertronURL for https://testgrid.k8s.io/sig-release-master-informing#gce-master-scale-performance&width=30: https://render-tron.appspot.com/screenshot/https:%2F%2Ftestgrid.k8s.io%2Fsig-release-master-informing%23gce-master-scale-performance&width=30?width=3000&height=2500 
INFO Sending GET request to https://render-tron.appspot.com/screenshot/https:%2F%2Ftestgrid.k8s.io%2Fsig-release-master-informing%23gce-master-scale-performance&width=30?width=3000&height=2500 
FATA processing the dashboards: failed to get the testgrid screenshot: HTTP error 404 Not Found for https://render-tron.appspot.com/screenshot/https:%2F%2Ftestgrid.k8s.io%2Fsig-release-master-informing%23gce-master-scale-performance&width=30?width=3000&height=2500

This error has been mentioned a couple of times before at least, see:

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Feb 14, 2023
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Feb 14, 2023
@ramrodo
Copy link
Member Author

ramrodo commented Feb 14, 2023

/cc @cici37 @gracenng

@cici37
Copy link
Contributor

cici37 commented Feb 15, 2023

Thanks for the PR!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2023
@cici37
Copy link
Contributor

cici37 commented Feb 15, 2023

/assign @cpanato @puerco
for approval if you have time? Thank you

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have an alternative to rendertron?

@ramrodo
Copy link
Member Author

ramrodo commented Feb 15, 2023

Do we have an alternative to rendertron?

Good question @saschagrunert. I could not find a free and reliable tool to take screenshots online (without installing other dependencies). I found this screenshotmachine site that allows us to take 100 screenshots free per month but we need to create an account to get a token. Not sure if we have an org account for these types of services.

@cici37
Copy link
Contributor

cici37 commented Feb 15, 2023

I plan to update the doc and issue template to let people manually add testgrid status as of now before a replacement is in place. This PR at least will help in terms of generating testgrid status without throwing errors. Maybe the issue for finding/applying replacement of Rendertron?

@palnabarun
Copy link
Member

We can continue exploring #2783 by @xmudrii to replace rendertron.

@xmudrii
Copy link
Member

xmudrii commented Feb 15, 2023

I've been a bit busy with work and KEP-1731, but I'm happy to pick this up again in near future. There are some things that I need to fix in #2783 but in general it works pretty well.

@cici37
Copy link
Contributor

cici37 commented Feb 16, 2023

Thanks for sharing! I have closed the issue since the work is planned and ongoing :)

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move forward with this one and let #2783 provide a future replacement.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2023
Copy link
Member

@palnabarun palnabarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@palnabarun
Copy link
Member

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority labels Feb 16, 2023
@cpanato
Copy link
Member

cpanato commented Feb 16, 2023

agree
/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, palnabarun, ramrodo, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 61ad093 into kubernetes:master Feb 16, 2023
@ramrodo ramrodo deleted the remove-rendertron-shot branch February 22, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants