Use patched nftables binaries in distroless-iptables#4419
Open
danwinship wants to merge 1 commit into
Open
Conversation
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
added
kind/bug
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
?
What this PR does / why we need it:
Discussion in kubernetes/kubernetes#136786. We basically have to build our kube-proxy images with a patched old
nftbinary, to avoid the crash with kube-proxy nft 1.0.6 and system nft 1.1.3+. (Note that "use a newer version of nft" is not a suitable alternative because then we become a cause of the "mismatched nft versions cause crashes" problem rather than being a victim of it.)Which issue(s) this PR fixes:
Fixes kubernetes/kubernetes#136786
Special notes for your reviewer:
See https://github.com/danwinship/debian-nftables/tree/bookworm-k8s/k8s for details of how the patched debs were produced. Building patched debs seemed like the simplest approach because the
distroless-iptablesbuild process uses the dpkg metadata to figure out which files it needs to copy to the final image.Rather than trying to figure out how to sign the packages and then importing a key here and checking their integrity that way, I just recorded the sha256sums of the packages I had built, and had the build script here verify that it got the right ones. This may or may not have been a good idea. (Also, originally I forgot that I needed both
nftablesandlibnftables1, so I ended up implementing the "array lookup" a little redundantly.)Anyway, this seems to all work, but maybe we want to do things differently, either here or with the patched-deb build process...
/cc @aojea @BenTheElder
Does this PR introduce a user-facing change?