Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes-ci-images => k8s-staging-ci-images #21548

Closed

Conversation

BobyMCbobs
Copy link
Member

Promote use of k8s-staging-ci-images.

Related: kubernetes/k8s.io#1460

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 29, 2021
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 29, 2021
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

These are deprecated build jobs, but probably good to go ahead and move them over as well. Thanks @BobyMCbobs!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BobyMCbobs, hasheddan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2021
@justaugustus
Copy link
Member

/hold
/lgtm cancel

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 29, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2021
@hasheddan
Copy link
Contributor

Oh just realized these are to hold over until the switch is complete. Thanks @justaugustus !

@hasheddan
Copy link
Contributor

hasheddan commented Mar 29, 2021

I wonder if it would make sense to remove this job with the release of a new version (e.g. v1.21) so that consumers will break when they consume a new version of k8s. This wouldn't really make a difference for folks consuming version markers, but it would provide a tangible cut-off at which support was dropped, rather than dropping support across all active releases at a given time.

@justaugustus
Copy link
Member

justaugustus commented Mar 29, 2021

Oh just realized these are to hold over until the switch is complete. Thanks @justaugustus !

Yep! These jobs were marked as deprecated in #20964.

As part of kubernetes/release#1711 (using krel for CI builds), #20663 set the krel ci-build as the de facto CI build.

Let's hang tight for Aaron to provide feedback on what he wànts next steps to be.

/assign @spiffxp

EDIT:
I'm thinking a few things:

  • build consumers use the new community version markers
  • once completed, these jobs get removed

@alvaroaleman
Copy link
Member

@BobyMCbobs: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 3, 2021
@BobyMCbobs BobyMCbobs force-pushed the promot-use-of-k8s-staging-ci-images branch from d217087 to 923638e Compare April 5, 2021 20:40
@BobyMCbobs
Copy link
Member Author

Rebased now, @alvaroaleman

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 5, 2021
@cpanato
Copy link
Member

cpanato commented Jun 8, 2021

@hasheddan @justaugustus this is something we still want to move? what are the blockers to merge this PR? there is anything that I can help to unblock this?

@spiffxp
Copy link
Member

spiffxp commented Jun 9, 2021

/close
Deprecated jobs need to keep pushing to the deprecated locations.

Closure would look like:

  • announcing to the community that use of CI artifacts from kubernetes-ci-images and gs://kubernetes-release-dev is deprecated, with a deprecation window
  • dropping all use of the deprecated artifacts across the project
  • removing these deprecated build jobs after the deprecation window

It might be worth a KEP to enumerate the full scope of changes required, if not some iteration over a proposal or umbrella issue

ref: kubernetes/k8s.io#846
ref: kubernetes/k8s.io#1460

@k8s-ci-robot
Copy link
Contributor

@spiffxp: Closed this PR.

In response to this:

/close
Deprecated jobs need to keep pushing to the deprecated locations.

Closure would look like:

  • announcing to the community that use of CI artifacts from kubernetes-ci-images and gs://kubernetes-release-dev is deprecated, with a deprecation window
  • dropping all use of the deprecated artifacts across the project
  • removing these deprecated build jobs after the deprecation window

It might be worth a KEP to enumerate the full scope of changes required, if not some iteration over a proposal or umbrella issue

ref: kubernetes/k8s.io#846
ref: kubernetes/k8s.io#1460

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants