Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove umigrated secrets store CSI jobs, cleanup TODO #33231

Merged
merged 4 commits into from
Aug 5, 2024
Merged

remove umigrated secrets store CSI jobs, cleanup TODO #33231

merged 4 commits into from
Aug 5, 2024

Conversation

BenTheElder
Copy link
Member

after this has merged and there have been no runs, next up is the legacy GCP janitor jobs (#33129)

refer to #33226

@BenTheElder
remove unmigrated secrets-store-csi-driver jobs
c843414 
will unblock removing the GCP janitors next
@BenTheElder
update migration TODO
8b4af68
@BenTheElder
update known bad jobs generation comment
efcfcbd
@BenTheElder
update known bad jobs
ddd0787 
NOTE: sorting in the source file changed when we added secrets. this is a one-time churn to the sort order, with net removals
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 5, 2024
@k8s-ci-robot k8s-ci-robot requested review from dims and tam7t August 5, 2024 22:44
@BenTheElder
Copy link
Member Author

another breadcrumb: kubernetes-sigs/secrets-store-csi-driver#1583 (comment)

michelle192837
michelle192837 approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@michelle192837 michelle192837 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

Unhold at will

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder BenTheElder mentioned this pull request Aug 5, 2024
Merged
@BenTheElder
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2024
@BenTheElder
Copy link
Member Author

/skip

@k8s-ci-robot k8s-ci-robot merged commit 515edb5 into kubernetes:master Aug 5, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key secrets-store-csi-driver-config.yaml using file config/jobs/kubernetes-sigs/secrets-store-csi-driver/secrets-store-csi-driver-config.yaml

In response to this:

after this has merged and there have been no runs, next up is the legacy GCP janitor jobs (#33129)

refer to #33226

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@BenTheElder BenTheElder deleted the secrets-store-removal branch August 5, 2024 22:58
This was referenced Aug 5, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelle192837 michelle192837 michelle192837 approved these changes

@dims dims Awaiting requested review from dims

@tam7t tam7t Awaiting requested review from tam7t

Assignees

@michelle192837 michelle192837

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenTheElder @k8s-ci-robot @michelle192837