Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add external-snapshot-metadata repo to CSI jobs #33303

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add external-snapshot-metadata repo to CSI jobs #33303

wants to merge 3 commits into from

Conversation

hairyhum
Copy link

Added external-snapshot-metadata to config/jobs/kubernetes-csi/gen-jobs.sh and config/jobs/image-pushing/k8s-staging-sig-storage.sh and generated the jobs.

Added external-snapshot-metadata to config/testgrids/kubernetes/sig-storage/config.yaml dashboards.

This is a part of setting up the CI for https://github.com/kubernetes-csi/external-snapshot-metadata

Related:
kubernetes-csi/external-snapshot-metadata#19
kubernetes-csi/external-snapshot-metadata#6

I might have missed or misconfigured something, so would appreciate any feedback.

@hairyhum
Add external-snapshot-metadata repo to CSI jobs
4f0b35d 
Added `external-snapshot-metadata` to `config/jobs/kubernetes-csi/gen-jobs.sh`
and `config/jobs/image-pushing/k8s-staging-sig-storage.sh` and generated the jobs

Added `external-snapshot-metadata` to `config/testgrids/kubernetes/sig-storage/config.yaml` dashboards
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 12, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @hairyhum!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @hairyhum. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 12, 2024
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/testgrid sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 12, 2024
@hairyhum
Copy link
Author

@xing-yang can you please take a look?

@xing-yang
Copy link
Contributor

/assign

@xing-yang
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 21, 2024
@hairyhum
Copy link
Author

@xing-yang all tests look green, can you do a review?

xing-yang
xing-yang reviewed Sep 10, 2024
View reviewed changes
config/jobs/kubernetes-csi/external-snapshot-metadata/external-snapshot-metadata-config.yaml
@@ -0,0 +1,433 @@
# generated by gen-jobs.sh, do not edit manually
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file generated by running gen-jobs.sh? We recently updated K8s versions in gen-jobs.sh. Please re-run it. We should have jobs for 1.29-1.31.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regenerated.

@hairyhum
Copy link
Author

@xing-yang ready for another review

@hairyhum hairyhum mentioned this pull request Sep 18, 2024
Open
11 tasks
@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hairyhum, xing-yang
Once this PR has been reviewed and has the lgtm label, please assign mpherman2, saad-ali for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@saad-ali saad-ali Awaiting requested review from saad-ali

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@xing-yang xing-yang

Labels
area/config Issues or PRs related to code in /config area/jobs area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hairyhum @k8s-ci-robot @xing-yang