Skip to content

cloud-provider-gcp: run cloud-provider-gcp-tests by calling script#35877

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
justinsb:bazelectomy_cloud-provider-gcp-tests
Jan 16, 2026
Merged

cloud-provider-gcp: run cloud-provider-gcp-tests by calling script#35877
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
justinsb:bazelectomy_cloud-provider-gcp-tests

Conversation

@justinsb
Copy link
Member

@justinsb justinsb commented Nov 6, 2025

We have a script that defines the desired content of this job,
in dev/ci/presubmits/cloud-provider-gcp-tests.

In general, we want to keep the logic in our own repo,
and keep (only) prow configuration in prow.

We have a script that defines the desired content of this job,
in `dev/ci/presubmits/cloud-provider-gcp-tests`.

In general, we want to keep the logic in our own repo,
and keep (only) prow configuration in prow.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 6, 2025
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/jobs area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 6, 2025
@justinsb
Copy link
Member Author

justinsb commented Nov 6, 2025

This is in support of kubernetes/cloud-provider-gcp#916 , but is also working towards keeping non-prow logic out of prow config.

/assign @cheftako

@justinsb
Copy link
Member Author

justinsb commented Nov 6, 2025

Bizarrely though, it looks like the tests are failing at head right now...

@hdp617
Copy link

hdp617 commented Jan 15, 2026

This change makes sense to me.

@cheftako @YifeiZhuang Could you approve this change? Thanks!

@YifeiZhuang
Copy link
Contributor

/LGTM
I am not an approver in the OWNER file.
cc. @aojea

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2026
@aojea
Copy link
Member

aojea commented Jan 16, 2026

/lgtm
/approve

cc:@xiaoweim

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2026
@k8s-ci-robot k8s-ci-robot merged commit 1c8ca69 into kubernetes:master Jan 16, 2026
6 checks passed
@k8s-ci-robot
Copy link
Contributor

@justinsb: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cloud-provider-gcp-presubmits.yaml using file config/jobs/kubernetes/cloud-provider-gcp/cloud-provider-gcp-presubmits.yaml
Details

In response to this:

We have a script that defines the desired content of this job,
in dev/ci/presubmits/cloud-provider-gcp-tests.

In general, we want to keep the logic in our own repo,
and keep (only) prow configuration in prow.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants