cloud-provider-gcp: run cloud-provider-gcp-tests by calling script#35877
Conversation
We have a script that defines the desired content of this job, in `dev/ci/presubmits/cloud-provider-gcp-tests`. In general, we want to keep the logic in our own repo, and keep (only) prow configuration in prow.
|
This is in support of kubernetes/cloud-provider-gcp#916 , but is also working towards keeping non-prow logic out of prow config. /assign @cheftako |
|
Bizarrely though, it looks like the tests are failing at head right now... |
|
This change makes sense to me. @cheftako @YifeiZhuang Could you approve this change? Thanks! |
|
/LGTM |
|
/lgtm cc:@xiaoweim |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@justinsb: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
We have a script that defines the desired content of this job,
in
dev/ci/presubmits/cloud-provider-gcp-tests.In general, we want to keep the logic in our own repo,
and keep (only) prow configuration in prow.