Skip to content

Conversation

@upodroid
Copy link
Member

I made a couple of important tweaks:

  • You can now configure which versions of kops a distro will work with. For example, rhel10 was introduced in kops 1.34, but we don't want to run it for versions older than 1.34 as it won't work.
  • I changed the k8s markers to use the release branch CI builds instead of the prod release. What this means is that we can test for example, the latest code in release-1.34 branch of k/k instead of 1.34.x release.
  • The change above allows k8s 1.35 to be tested now

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 14, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/testgrid sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 14, 2025
@upodroid upodroid requested a review from hakman December 14, 2025 15:47
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 14, 2025
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 14, 2025
@hakman
Copy link
Member

hakman commented Dec 14, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2025
{%- if run_if_changed %}
run_if_changed: '{{run_if_changed}}'
{%- endif %}
{%- if cloud == "gce" and scenario == "scalability" %}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I introduced a concurrency limit in #35700 for the GCE 5k jobs, applying it to our presubmits too.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2025
@hakman
Copy link
Member

hakman commented Dec 14, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2025
@k8s-ci-robot k8s-ci-robot merged commit 0493a77 into kubernetes:master Dec 14, 2025
6 checks passed
@k8s-ci-robot
Copy link
Contributor

@upodroid: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kops-periodics-conformance.yaml using file config/jobs/kubernetes/kops/kops-periodics-conformance.yaml
  • key kops-periodics-grid.yaml using file config/jobs/kubernetes/kops/kops-periodics-grid.yaml
  • key kops-periodics-misc2.yaml using file config/jobs/kubernetes/kops/kops-periodics-misc2.yaml
  • key kops-periodics-network-plugins.yaml using file config/jobs/kubernetes/kops/kops-periodics-network-plugins.yaml
  • key kops-periodics-nftables.yaml using file config/jobs/kubernetes/kops/kops-periodics-nftables.yaml
  • key kops-periodics-pipeline.yaml using file config/jobs/kubernetes/kops/kops-periodics-pipeline.yaml
  • key kops-periodics-versions.yaml using file config/jobs/kubernetes/kops/kops-periodics-versions.yaml
  • key kops-presubmits-distros.yaml using file config/jobs/kubernetes/kops/kops-presubmits-distros.yaml
  • key kops-presubmits-e2e.yaml using file config/jobs/kubernetes/kops/kops-presubmits-e2e.yaml
  • key kops-presubmits-network-plugins.yaml using file config/jobs/kubernetes/kops/kops-presubmits-network-plugins.yaml
  • key kops-presubmits-scale.yaml using file config/jobs/kubernetes/kops/kops-presubmits-scale.yaml
Details

In response to this:

I made a couple of important tweaks:

  • You can now configure which versions of kops a distro will work with. For example, rhel10 was introduced in kops 1.34, but we don't want to run it for versions older than 1.34 as it won't work.
  • I changed the k8s markers to use the release branch CI builds instead of the prod release. What this means is that we can test for example, the latest code in release-1.34 branch of k/k instead of 1.34.x release.
  • The change above allows k8s 1.35 to be tested now

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants