Skip to content

Add dashboard group for CAPV #36110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fabriziopandini wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add dashboard group for CAPV #36110

fabriziopandini wants to merge 1 commit into from

Conversation

@fabriziopandini
Copy link
Member

@fabriziopandini fabriziopandini commented Dec 19, 2025

This PR creates a new dashboard group for CAPV, like we recently did for CAPI

cc @neolit123 (thanks again for suggesting this approach)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/testgrid labels Dec 19, 2025
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 19, 2025
@neolit123
Copy link
Member

neolit123 commented Dec 19, 2025

note that we got permission from SIG Testing only about CAPI core.
we did not discuss other SIG CL subprojects.

@fabriziopandini fabriziopandini force-pushed the reorg-CAPI-CAPV-dashboards branch from 5a79882 to 5dc2371 Compare December 19, 2025 14:10
@fabriziopandini
Copy link
Member Author

fabriziopandini commented Dec 19, 2025

note that we got permission from SIG Testing only about CAPI core.
we did not discuss other SIG CL subprojects.

ACK, let's see what they think.
Considering the number of jobs/branches in CAPV, a better dashboard organization could really help (the list of jobs in https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api-provider-vsphere is hardly usable since some time now)

@fabriziopandini fabriziopandini force-pushed the reorg-CAPI-CAPV-dashboards branch 2 times, most recently from a83f593 to 9f234a5 Compare December 22, 2025 13:52
sbueringer
sbueringer reviewed Dec 22, 2025
View reviewed changes
...-sigs/cluster-api-provider-vsphere/cluster-api-provider-vsphere-main-periodics-upgrades.yaml
cpu: "4000m"
memory: "6Gi"
limits:
cpu: "4000m"
Copy link
Member

@sbueringer sbueringer Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's restore/keep: config/jobs/kubernetes-sigs/cluster-api-provider-vsphere/cluster-api-provider-vsphere-main-debug.yaml

Copy link
Member Author

@fabriziopandini fabriziopandini Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

config/tests/testgrids/config_test.go
"conformance",
"minikube",
"cluster-api-core",
"cluster-api",
Copy link
Member

@sbueringer sbueringer Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think cluster-api-core and cluster-api-provider-vsphere should be listed here separately

Copy link
Member Author

@fabriziopandini fabriziopandini Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a prefix check, it does not require an exact match

config/testgrids/kubernetes/cluster-api-provider-vsphere/config.yaml
@@ -0,0 +1,13 @@
dashboard_groups:
- name: cluster-api-provider-vsphere
Copy link
Member

@sbueringer sbueringer Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this name has to match the folder name

Copy link
Member Author

@fabriziopandini fabriziopandini Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it does not matter, because it looks like the code is traversing the tree and collecting yaml.
I'm fine keeping this way or renaming it, as you prefer

Copy link
Member Author

@fabriziopandini fabriziopandini Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed

@sbueringer
Copy link
Member

sbueringer commented Dec 22, 2025

/assign @dims

For context, similar to #35269

@fabriziopandini fabriziopandini force-pushed the reorg-CAPI-CAPV-dashboards branch from 9f234a5 to f228209 Compare December 22, 2025 14:49
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fabriziopandini
Once this PR has been reviewed and has the lgtm label, please ask for approval from dims. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fabriziopandini fabriziopandini force-pushed the reorg-CAPI-CAPV-dashboards branch from f228209 to 6b8b510 Compare December 22, 2025 14:59
@sbueringer
Copy link
Member

sbueringer commented Dec 22, 2025

Thx!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gab-satchi gab-satchi Awaiting requested review from gab-satchi

@justinsb justinsb Awaiting requested review from justinsb

1 more reviewer

@sbueringer sbueringer sbueringer left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dims dims

@sbueringer sbueringer

Labels

area/config Issues or PRs related to code in /config area/jobs area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fabriziopandini @neolit123 @sbueringer @k8s-ci-robot @dims