-
Notifications
You must be signed in to change notification settings - Fork 2.8k
chore: add optional presubmit for openbao provider with secrets-store-csi #36141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add optional presubmit for openbao provider with secrets-store-csi #36141
Conversation
Signed-off-by: Toni Tauro <[email protected]>
|
Welcome @eyenx! |
|
Hi @eyenx. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
aramase
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment about making the job optional to start off.
config/jobs/kubernetes-sigs/secrets-store-csi-driver/secrets-store-csi-driver-config.yaml
Outdated
Show resolved
Hide resolved
|
/retitle chore: add optional presubmit for openbao provider with secrets-store-csi |
|
@aramase done |
config/jobs/kubernetes-sigs/secrets-store-csi-driver/secrets-store-csi-driver-config.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Toni Tauro <[email protected]>
aramase
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/label tide/merge-method-squash
config/jobs/kubernetes-sigs/secrets-store-csi-driver/secrets-store-csi-driver-config.yaml
Outdated
Show resolved
Hide resolved
|
Oh damn autolinter, changed the whole file, let me redo it... |
Signed-off-by: Toni Tauro <[email protected]>
06d42c1 to
b5b27d1
Compare
aramase
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aramase, eyenx The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@eyenx: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Adds an optional presubmit job to validate openbao provider with secrets-store-csi-driver.
After this PR is merged, tests can be manually triggered in PRs with /test pull-secrets-store-csi-driver-e2e-openbao
Similar to #32573
Needed to unblock kubernetes-sigs/secrets-store-csi-driver#1902