Skip to content

Conversation

@eyenx
Copy link
Contributor

@eyenx eyenx commented Dec 30, 2025

Adds an optional presubmit job to validate openbao provider with secrets-store-csi-driver.

After this PR is merged, tests can be manually triggered in PRs with /test pull-secrets-store-csi-driver-e2e-openbao

Similar to #32573

Needed to unblock kubernetes-sigs/secrets-store-csi-driver#1902

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 30, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @eyenx!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 30, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @eyenx. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 30, 2025
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about making the job optional to start off.

@aramase
Copy link
Member

aramase commented Jan 5, 2026

/retitle chore: add optional presubmit for openbao provider with secrets-store-csi

@k8s-ci-robot k8s-ci-robot changed the title feat(e2e/csi-secrets-store-driver): add openbao chore: add optional presubmit for openbao provider with secrets-store-csi Jan 5, 2026
@eyenx
Copy link
Contributor Author

eyenx commented Jan 5, 2026

@aramase done

Signed-off-by: Toni Tauro <[email protected]>
@eyenx eyenx requested a review from aramase January 6, 2026 18:56
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 6, 2026
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 6, 2026
@eyenx
Copy link
Contributor Author

eyenx commented Jan 6, 2026

Oh damn autolinter, changed the whole file, let me redo it...

Signed-off-by: Toni Tauro <[email protected]>
@eyenx eyenx force-pushed the feat/add-openbao-csi-secrets-store-e2e branch from 06d42c1 to b5b27d1 Compare January 6, 2026 20:06
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 6, 2026
@eyenx eyenx requested a review from aramase January 6, 2026 20:24
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase, eyenx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2026
@k8s-ci-robot k8s-ci-robot merged commit f36ce7b into kubernetes:master Jan 6, 2026
6 checks passed
@k8s-ci-robot
Copy link
Contributor

@eyenx: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key secrets-store-csi-driver-config.yaml using file config/jobs/kubernetes-sigs/secrets-store-csi-driver/secrets-store-csi-driver-config.yaml
Details

In response to this:

Adds an optional presubmit job to validate openbao provider with secrets-store-csi-driver.

After this PR is merged, tests can be manually triggered in PRs with /test pull-secrets-store-csi-driver-e2e-openbao

Similar to #32573

Needed to unblock kubernetes-sigs/secrets-store-csi-driver#1902

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@eyenx eyenx deleted the feat/add-openbao-csi-secrets-store-e2e branch January 6, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants