-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Update OWNER_ALIASES for Kubebuilder #36152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update OWNER_ALIASES for Kubebuilder #36152
Conversation
|
Welcome @vitorfloriano! |
|
Hi @vitorfloriano. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@camilamacedo86 PTAL |
OWNERS_ALIASES
Outdated
| kubebuilder-emeritus-approvers: | ||
| - adirio | ||
| - directxman12 | ||
| - droot | ||
| - estroz | ||
| - jmrodri | ||
| - joelanford | ||
| - mengqiy | ||
| - pwittrock | ||
|
|
||
| kubebuilder-emeritus-reviewers: | ||
| - everettraven |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vitorfloriano the emeritus I think we should not add
Those field are from people that are no longer active in the project.
Thank you a lot for looking on this one.
Could you please remove those?
Then, I think I can approve and lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! @camilamacedo86 do you think this can be a blocker:
The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the kubernetes org. You can then trigger verification by writing
/verify-ownersin a comment.
rashmigottipati
- User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.
vitorfloriano
- User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, you need to become member of the org to be in an owners file
7c3690a to
c5579c5
Compare
camilamacedo86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/approved |
|
/lgtm cancel |
OWNERS_ALIASES
Outdated
| kubebuilder-emeritus-approvers: | ||
| - pwittrock | ||
| kubebuilder-reviewers: | ||
| - rashmigottipati |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vitorfloriano sorry
Could we either remove rashmigottipati
She probably should be moved to emeritus too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I moved rashmigottipati to emeritus and opened a PR to add myself to the Kubernetes org.
See kubernetes/org#6042 and kubernetes-sigs/kubebuilder#5341
c5579c5 to
e893f14
Compare
OWNERS_ALIASES
Outdated
| kubebuilder-reviewers: | ||
| - alexeldeib | ||
| kubebuilder-approvers: | ||
| - Kavinjsir |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vitorfloriano sorry
Could we either remove Kavinjsir
We might need to also move he for emeritus too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
I also updated the PR on kubebuilder: kubernetes-sigs/kubebuilder/pull/5341
e893f14 to
d252795
Compare
The Kubebuilder section in OWNER_ALIASES are now up-to-date with the current owners in the Kubebuilder repo.
|
The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the kubernetes org. You can then trigger verification by writing
|
camilamacedo86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: camilamacedo86, vitorfloriano The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@vitorfloriano is saying that you not a member as well So, we might have an issue with the check Could you please help us out on this one? |
I'm a member of We need to wait for it to be merged. |
|
https://github.com/search?q=repo%3Akubernetes%2Ftest-infra+kubebuilder+path%3AOWNERS&type=code With a single file using this alias, it will be easier to just not use an alias.
|
The Kubebuilder section in OWNER_ALIASES is now up-to-date with the current owners in the Kubebuilder repo.
Closes kubernetes-sigs/kubebuilder#5331