Skip to content

Conversation

@vitorfloriano
Copy link

The Kubebuilder section in OWNER_ALIASES is now up-to-date with the current owners in the Kubebuilder repo.

Closes kubernetes-sigs/kubebuilder#5331

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Jan 3, 2026
@k8s-ci-robot
Copy link
Contributor

Welcome @vitorfloriano!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 3, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @vitorfloriano. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot requested review from aojea and upodroid January 3, 2026 00:58
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Jan 3, 2026
@vitorfloriano
Copy link
Author

@camilamacedo86 PTAL

OWNERS_ALIASES Outdated
Comment on lines 321 to 332
kubebuilder-emeritus-approvers:
- adirio
- directxman12
- droot
- estroz
- jmrodri
- joelanford
- mengqiy
- pwittrock

kubebuilder-emeritus-reviewers:
- everettraven
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vitorfloriano the emeritus I think we should not add
Those field are from people that are no longer active in the project.

Thank you a lot for looking on this one.
Could you please remove those?
Then, I think I can approve and lgtm

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! @camilamacedo86 do you think this can be a blocker:

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the kubernetes org. You can then trigger verification by writing /verify-owners in a comment.

  • rashmigottipati

    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.
  • vitorfloriano

    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you need to become member of the org to be in an owners file

Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2026
@camilamacedo86
Copy link
Contributor

/approved

@camilamacedo86
Copy link
Contributor

/lgtm cancel
/approved cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2026
OWNERS_ALIASES Outdated
kubebuilder-emeritus-approvers:
- pwittrock
kubebuilder-reviewers:
- rashmigottipati
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vitorfloriano sorry

Could we either remove rashmigottipati
She probably should be moved to emeritus too.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I moved rashmigottipati to emeritus and opened a PR to add myself to the Kubernetes org.

See kubernetes/org#6042 and kubernetes-sigs/kubebuilder#5341

OWNERS_ALIASES Outdated
kubebuilder-reviewers:
- alexeldeib
kubebuilder-approvers:
- Kavinjsir
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vitorfloriano sorry

Could we either remove Kavinjsir
We might need to also move he for emeritus too

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

I also updated the PR on kubebuilder: kubernetes-sigs/kubebuilder/pull/5341

The Kubebuilder section in OWNER_ALIASES are now up-to-date with the
current owners in the Kubebuilder repo.
@k8s-ci-robot
Copy link
Contributor

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the kubernetes org. You can then trigger verification by writing /verify-owners in a comment.

  • vitorfloriano
    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.

Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: camilamacedo86, vitorfloriano
Once this PR has been reviewed and has the lgtm label, please assign bentheelder for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86
Copy link
Contributor

@vitorfloriano is saying that you not a member as well
But as far as I know you are see; kubernetes/org#6007

So, we might have an issue with the check
@BenTheElder

Could you please help us out on this one?

@vitorfloriano
Copy link
Author

@vitorfloriano is saying that you not a member as well But as far as I know you are see; kubernetes/org#6007

So, we might have an issue with the check @BenTheElder

Could you please help us out on this one?

I'm a member of kubernetes-sigs, but I've already opened a PR to add myself to kubernetes as well. See kubernetes/org#6042.

We need to wait for it to be merged.

@BenTheElder
Copy link
Member

https://github.com/search?q=repo%3Akubernetes%2Ftest-infra+kubebuilder+path%3AOWNERS&type=code

With a single file using this alias, it will be easier to just not use an alias.

  • you can self-approve updates to your own OWNERS files for jobs for your repo in the future
  • less opaque to contributors (they can directly see who can approve from the bot comment link without the further complexity of finding the alias file and cross-referencing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update k8s/test-infra owner alias

5 participants