Skip to content

wip: migrate yaml linting to "kubernetes-sigs/yaml" #36183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
medyagh wants to merge 7 commits into
base: master
Choose a base branch
from
Open

wip: migrate yaml linting to "kubernetes-sigs/yaml" #36183

medyagh wants to merge 7 commits into from
+269 −238

Conversation

@medyagh
Copy link
Member

@medyagh medyagh commented Jan 8, 2026 •
edited
Loading

Per discussion here
#36114 (comment)

  • Removed 2 years old "yamllint" (docker-based) and introduced yamlfmt (go module-based).

  • New Scripts:
    -- hack/make-rules/update/yamlfmt.sh: Formats YAML files in config/jobs and config/prow/cluster.
    -- hack/make-rules/verify/yamlfmt.sh: Verifies formatting (used in CI).

  • Makefile Updates:
    -- Replaced verify-yamllint with verify-yamlfmt.
    -- Added update-yamlfmt.
    -- Cleanup: Deleted hack/make-rules/verify/yamllint.sh and config/jobs/.yamllint.conf.

  • DRA updates (to generate jobs)
    changes to dra ninja template to match yamlfter

how to use

make update-yamlfmt

running the make update-yamlfmt will cause changing 546 files (as seen here #36186) we could do either in the same PR or as a follow up.
I prefer this PR be reviewed first and approved first and we could do the linting in same PR or a follow up

TODO:

after we run make update-yamlfmt, I notice some mode changes (probably a link is being overwritten by yamlfmt) which need further investigation

 546 files changed, 311461 insertions(+), 339623 deletions(-)
 mode change 120000 => 100644 config/prow/cluster/build/build_kubernetes-external-secrets_crd.yaml
 mode change 120000 => 100644 config/prow/cluster/build/build_kubernetes-external-secrets_deployment.yaml
 mode change 120000 => 100644 config/prow/cluster/build/build_kubernetes-external-secrets_rbac.yaml
 mode change 120000 => 100644 config/prow/cluster/build/build_kubernetes-external-secrets_service.yaml

closes #36114

@medyagh medyagh changed the title migrate yaml linting to "kubernetes-sigs/yaml" wip: migrate yaml linting to "kubernetes-sigs/yaml" Jan 8, 2026
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 8, 2026
@k8s-ci-robot k8s-ci-robot requested review from aojea and upodroid January 8, 2026 23:40
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 8, 2026
This was referenced Jan 8, 2026
Open
Closed
Open
@aojea
Copy link
Member

aojea commented Jan 9, 2026

please run make update-go-deps
ERROR: go deps failed

@medyagh
Copy link
Member Author

medyagh commented Jan 9, 2026

please run make update-go-deps
ERROR: go deps failed

done, but still this PR wont pass the checks since the actual formatting is not done here,
checkout this PR
#36186

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. labels Jan 9, 2026
@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider area/testgrid size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 9, 2026
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. area/conformance Issues or PRs related to kubernetes conformance tests and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 9, 2026
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/provider/gcp Issues or PRs related to gcp provider sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/windows Categorizes an issue or PR as relevant to SIG Windows. labels Jan 13, 2026
@medyagh
chore: Migrate from yamllint to yamlfmt for YAML formatting and verif…
3f1ab70 
…ication.
@medyagh
feat: migrate YAML formatting and verification from yamllint to yamlf…
b546924 
…mt, updating dependencies and build scripts.
@medyagh
update go.sum
ce56ee5
@medyagh
refactor: introduce conditional indentation for job definitions based…
248efb2 
… on the `ci` variable.
@medyagh
- Fixing Indentation to match yamlfmt requires list items (like args:…
5c1e166 
…, env:) to be indented 2 spaces relative to their parent key. The original template sometimes had them at the same level or aligned incorrectly. We shifted them to match the standard.

- Removing "Invisible" Newlines: Loop and Option tags in Jinja (like {% if %}) leave behind blank lines by default. We changed them to {%- if -%} (adding hyphens) to tell Jinja: "Execute this logic, but strip the whitespace around it." This stopped valid code from being pushed apart by random blank lines.

- Stripping the End: We added {%- endfilter -%} at the very end. This removes all trailing newlines from the template output itself, giving the Python script full control over how jobs are separated.
@medyagh
by explicitly writing \n in the Python script after each job is rende…
f7216d6 
…red, we ensure that:

There is exactly one newline between jobs (separating them cleanly).
There is exactly one newline at the end of the file (making it a valid text file).
@medyagh
fix: correct indentation for spec and containers in dra.jinja to matc…
b72f839 
…h yamlfmt
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: medyagh
Once this PR has been reviewed and has the lgtm label, please assign dims for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 13, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 13, 2026

@medyagh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-test-infra-verify-lint b72f839 link true /test pull-test-infra-verify-lint

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 13, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2026
@mariafromano-25 mariafromano-25 moved this from Triage to Archive-it in SIG Node CI/Test Board Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aojea aojea Awaiting requested review from aojea

@upodroid upodroid Awaiting requested review from upodroid

Assignees

No one assigned

Labels

area/config Issues or PRs related to code in /config area/conformance Issues or PRs related to kubernetes conformance tests area/jobs area/provider/azure Issues or PRs related to azure provider area/provider/gcp Issues or PRs related to gcp provider area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

SIG Node CI/Test Board
Status: Archive-it

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

yamlint image: doesnt support arm64 and 2 years old

3 participants

@medyagh @aojea @k8s-ci-robot