-
Notifications
You must be signed in to change notification settings - Fork 2.9k
prow: add presubmit job for node-readiness-controller #36261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
prow: add presubmit job for node-readiness-controller #36261
Conversation
|
Welcome @Hii-Himanshu! |
|
Hi @Hii-Himanshu. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@Priyankasaggu11929 I’ve opened the PR against the kubernetes/test-infra repo as discussed. Happy to iterate based on feedback. |
| approvers: | ||
|
|
||
| reviewers: | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hii-Himanshu, please copy the OWNERS similar to the node-readiness-controller repo here under both approvers and reviewers for now.
| kubernetes-sigs/node-readiness-controller: | ||
| - name: pull-org-verify-all | ||
| always_run: true | ||
| decorate: true | ||
| spec: | ||
| containers: | ||
| - image: | ||
| command: | ||
| - make | ||
| args: | ||
| - verify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hii-Himanshu, please add all fields to the job definition similar to what i provided in the reference job link I provided you.
I will review it again after. Thank you!
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Hii-Himanshu The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This PR adds a presubmit Prow job for the node-readiness-controller repository.