Skip to content

Conversation

@Choraden
Copy link
Contributor

This matches the configuration of the corresponding periodic job 'ci-kubernetes-e2e-gci-gce-autoscaling'.

…scaler repo

This matches the configuration of the corresponding periodic job 'ci-kubernetes-e2e-gci-gce-autoscaling'.
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 26, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @Choraden. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Choraden
Once this PR has been reviewed and has the lgtm label, please assign jackfrancis for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 26, 2026
@adrianmoisey
Copy link
Member

Is this related to the work you're doing in kubernetes/autoscaler#9023 ?

@Choraden
Copy link
Contributor Author

Hi @adrianmoisey,

Yes, this is directly related.

This change fixes the E2E presubmit job, as the cluster_size_autoscaling tests have been migrated to the autoscaler repository. Without this update, the job will continue to fail since there are no plans to maintain or fix those tests within the k/k repo.

This does raise a broader question of whether autoscaler manifests should be removed from k/k by now.
For the time being, I've kept them active to make the change more granular and easier to follow, at least for my own sanity.

@adrianmoisey
Copy link
Member

Great thanks!

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 26, 2026
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2026
@Choraden
Copy link
Contributor Author

/assign @towca

@Choraden
Copy link
Contributor Author

/assign @jackfrancis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants