-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Update pull-kubernetes-e2e-gci-gce-autoscaling to use tests from autoscaler repo #36307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…scaler repo This matches the configuration of the corresponding periodic job 'ci-kubernetes-e2e-gci-gce-autoscaling'.
|
Hi @Choraden. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Choraden The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Is this related to the work you're doing in kubernetes/autoscaler#9023 ? |
|
Hi @adrianmoisey, Yes, this is directly related. This change fixes the E2E presubmit job, as the This does raise a broader question of whether autoscaler manifests should be removed from k/k by now. |
|
Great thanks! /ok-to-test |
|
/assign @towca |
|
/assign @jackfrancis |
This matches the configuration of the corresponding periodic job 'ci-kubernetes-e2e-gci-gce-autoscaling'.