CAPG: Bump main presubmits to k8s 1.34 #36311
Draft
+11
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
sig/cluster-lifecycle
cpanato
approved these changes
Jan 27, 2026
k8s-ci-robot
added
the
lgtm
cpanato
suggested changes
Jan 27, 2026
...bernetes-sigs/cluster-api-provider-gcp/cluster-api-provider-gcp-presubmits-release-1-10.yaml
Outdated
Show resolved
Hide resolved
k8s-ci-robot
removed
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damdo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
damdo
force-pushed
the
capg-bump-to-k8s-1.34
branch
from
59971f6 to
3eae8ef
Compare
k8s-ci-robot
added
needs-rebase
damdo
force-pushed
the
capg-bump-to-k8s-1.34
branch
from
3eae8ef to
309ed12
Compare
k8s-ci-robot
removed
the
needs-rebase
Contributor
salasberryfin
left a comment
salasberryfin
left a comment
There was a problem hiding this comment.
Are we waiting for kubernetes-sigs/cluster-api-provider-gcp#1598 to be merged first? Otherwise tests would fail in CAPG, wouldn't they?
Member
Author
|
@salasberryfin I don't exactly recall the ordering, but that's my bet yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CAPG: Bump main presubmits to k8s 1.34.
Now that we'll start supporting k8s 1.34 we want to bump our presubmits