Skip to content

[KEP-3141] Placeholder PR to update docs for volume mode conversion GA #45261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[KEP-3141] Placeholder PR to update docs for volume mode conversion GA #45261

wants to merge 1 commit into from

Conversation

RaunakShah
Copy link
Contributor

Placeholder PR to update docs for volume mode conversion GA.
KEP - kubernetes/enhancements#3141

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Feb 21, 2024
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 21, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 21, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 8e09752
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65d7b12caa1e270008333098
😎 Deploy Preview https://deploy-preview-45261--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RaunakShah RaunakShah changed the title [KEP-3141] Placeholder commit to update docs for volume mode conversion GA [KEP-3141] Placeholder PR to update docs for volume mode conversion GA Feb 21, 2024
@RaunakShah RaunakShah mentioned this pull request Feb 21, 2024
Closed
10 tasks
dipesh-rawat
dipesh-rawat reviewed Feb 22, 2024
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RaunakShah, We should consider setting the dev-1.30 branch as the target branch rather than the main branch for this pull request. Since the change is related to the feature targeting 1.30.

@dipesh-rawat
Copy link
Member

/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Feb 22, 2024
@RaunakShah RaunakShah changed the base branch from main to dev-1.30 February 22, 2024 20:37
@k8s-ci-robot k8s-ci-robot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 22, 2024
@RaunakShah RaunakShah changed the base branch from dev-1.30 to main February 22, 2024 20:37
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign katcosgrove for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 22, 2024
@RaunakShah RaunakShah changed the base branch from main to dev-1.30 February 22, 2024 20:40
@RaunakShah
Copy link
Contributor Author

@dipesh-rawat done!

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 22, 2024
@drewhagen
Copy link
Member

Hello @RaunakShah 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before tomorrow March 12th 2024 18:00 PST. Thank you!

@RaunakShah
Copy link
Contributor Author

After speaking with @xing-yang, we don't have any updates to add to the k8s website. The changes will be made in the CSI docs - https://kubernetes-csi.github.io/docs/prevent-volume-mode-conversion.html
I've created a PR for this - kubernetes-csi/docs#589

Closing this PR as its no longer needed.

@RaunakShah RaunakShah closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

@thockin thockin Awaiting requested review from thockin

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RaunakShah @dipesh-rawat @k8s-ci-robot @drewhagen