Skip to content

Updated Kubernetes architecture image in tutorials #48193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Updated Kubernetes architecture image in tutorials #48193

wants to merge 4 commits into from

Conversation

utkarsh-singh1
Copy link
Contributor

@utkarsh-singh1 utkarsh-singh1 commented Oct 4, 2024 •
edited by sftim
Loading

Description

Updated the kubernetes architecture image in tutorial/kubernetes-basics/create-cluster.

Preview

Closes: #45619

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 4, 2024
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 4, 2024
@utkarsh-singh1
Copy link
Contributor Author

page link -> https://kubernetes.io/docs/tutorials/kubernetes-basics/create-cluster/cluster-intro/

@utkarsh-singh1
Copy link
Contributor Author

/sig docs

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Oct 4, 2024
@utkarsh-singh1
Copy link
Contributor Author

@dipak-pawar, @tengqm Updated the image in tutorial PTAL.

@netlify Netlify
Copy link

netlify bot commented Oct 4, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit f878304
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6796631ca2619c00084a86af
😎 Deploy Preview https://deploy-preview-48193--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Oct 15, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1bb790f01450814e2610f1a3b333ad03c9c1bae2

@utkarsh-singh1
Updated k8s-structure svg
e08df18 
Signed-off-by: utkarsh-singh1 <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2024
@k8s-ci-robot k8s-ci-robot requested a review from sftim October 16, 2024 03:10
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot added area/localization General issues or PRs related to localization language/hi Issues or PRs related to Hindi language size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 4, 2024
@utkarsh-singh1 utkarsh-singh1 marked this pull request as draft November 4, 2024 06:09
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 4, 2024
@sftim
Copy link
Contributor

sftim commented Jan 14, 2025

@utkarsh-singh1 what's your intention with this PR? It's been draft a while.

@utkarsh-singh1
Copy link
Contributor Author

@sftim, was not available for the changes.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from sftim. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 26, 2025
@utkarsh-singh1 utkarsh-singh1 marked this pull request as ready for review January 26, 2025 16:32
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 26, 2025
@utkarsh-singh1
Copy link
Contributor Author

Hi @sftim, @dipesh-rawat, Updated the PR and ready for review.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 7, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat Awaiting requested review from dipesh-rawat

@tengqm tengqm Awaiting requested review from tengqm

@sftim sftim Awaiting requested review from sftim

Assignees

@sftim sftim

Labels
area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language language/hi Issues or PRs related to Hindi language needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improvement for k8s.io/docs/tutorials/kubernetes-basics/create-cluster/cluster-intro/
3 participants
@utkarsh-singh1 @sftim @k8s-ci-robot