-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
service-accounts-admin.md: Explain invalidating short-lived tokens #48981
base: main
Are you sure you want to change the base?
Conversation
Welcome @jplitza! |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
content/en/docs/reference/access-authn-authz/service-accounts-admin.md
Outdated
Show resolved
Hide resolved
content/en/docs/reference/access-authn-authz/service-accounts-admin.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Utkarsh Singh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
This is a nice improvement.
/sig auth security
(aside: we should move a lot of this page out of the Reference section; a separate PR could create a tutorial to learn about ServiceAccounts, based on what we already have, and the reference page could directly link to sections within that tutorial).
/lgtm
LGTM label has been added. Git tree hash: 48487ce6678d6f014926754521b8f10c169a0edf
|
No tech review required BTW - ready for approval. |
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
The page "Managing Service Accounts" explains two types of tokens: short-lived tokens created via API and legacy/long-lived tokens created via Secrets.
The section about token deletion/invalidation however completely ignores the existence of short-lived tokens.
This PR fixes that and explains how to invalidate short-lived tokens.
Issue
Closes: #