Skip to content

Update the priority class docs to add the built in priority classes #49403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vaibhav2107
Copy link
Member

Description

Issue

Closes: #39000

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 13, 2025
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 13, 2025
Copy link

netlify bot commented Jan 13, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit f2f4748
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6784afa3bf0caf0008dc4030
😎 Deploy Preview https://deploy-preview-49403--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vaibhav2107
Copy link
Member Author

/cc @sftim
Could you please have a look

@k8s-ci-robot k8s-ci-robot requested a review from sftim January 13, 2025 06:47
@sftim
Copy link
Contributor

sftim commented Jan 13, 2025

/uncc

I'm happy for anyone to review this PR.

@k8s-ci-robot k8s-ci-robot removed the request for review from sftim January 13, 2025 10:16
@vaibhav2107
Copy link
Member Author

Hi @davidopp @piosz
Could you please have a look

@piosz
Copy link
Member

piosz commented Jan 20, 2025

@vaibhav2107 I'm not longer active in the community. Not sure about @davidopp

@aojea @wojtek-t would you be able to help redirecting accordingly?

@sftim
Copy link
Contributor

sftim commented Jan 20, 2025

@kubernetes/sig-node-pr-reviews do you want to review here?

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jan 20, 2025
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 20, 2025
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 20, 2025
Copy link
Contributor

@jayeshmahajan jayeshmahajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@github-project-automation github-project-automation bot moved this from Needs Reviewer to Waiting on Author in SIG Node: code and documentation PRs May 23, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nate-double-u for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Status: Waiting on Author
Development

Successfully merging this pull request may close these issues.

Guaranteed Scheduling For Critical Add-On Pods task does not link to details of built in PriorityClasses
6 participants