Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Docsy 0.6.0 via NPM module (1.31 backport) #49473

Open
wants to merge 11 commits into
base: release-1.31
Choose a base branch
from
Open

Upgrade to Docsy 0.6.0 via NPM module (1.31 backport) #49473

wants to merge 11 commits into from

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Jan 17, 2025

#49031 but a minor version newer

Upgrade the v1.31 docs to use Docsy 0.6.0

sftim and others added 4 commits December 12, 2024 02:29
@sftim
Use Docsy layout for community page
a665cc6 
Adapt the existing page to work with (near-)vanilla Docsy.

This includes new localizable strings.
@sftim
Amalgamate styles for Community page
37473a2 
Put legacy and current styles in one place, and simplify CSS load.
@chalin @sftim
Upgrade to Docsy 0.5.1 via NPM module
48044c5
@sftim
Work around footer issue
6c973ae
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes labels Jan 17, 2025
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 17, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 17, 2025 •
edited
Loading

✅ Deploy Preview for k8s-v1-31 ready!

Name Link
🔨 Latest commit 578f0cb
🔍 Latest deploy log https://app.netlify.com/sites/k8s-v1-31/deploys/678e7855930c060008d82d92
😎 Deploy Preview https://deploy-preview-49473--k8s-v1-31.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor Author

sftim commented Jan 17, 2025

I wouldn't squash the commits here; they are cherry picks and it's useful to maintain the link between the cherry pick and the original commit.

@netlify Netlify
Copy link

netlify bot commented Jan 17, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 578f0cb
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/678e7855f8c43e00083488e7
😎 Deploy Preview https://deploy-preview-49473--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim sftim force-pushed the 20250117_1-31_docsy_0-6 branch from c7066a1 to 14cbfe5 Compare January 20, 2025 09:05
@sftim sftim force-pushed the 20250117_1-31_docsy_0-6 branch from 14cbfe5 to 578f0cb Compare January 20, 2025 16:22
chalin
chalin approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chalin
Once this PR has been reviewed and has the lgtm label, please ask for approval from sftim. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chalin
Copy link
Contributor

chalin commented Jan 30, 2025

/lgtm

@k8s-ci-robot
Copy link
Contributor

@chalin: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@network-charles network-charles network-charles left review comments

@chalin chalin chalin approved these changes

@dipesh-rawat dipesh-rawat Awaiting requested review from dipesh-rawat

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

Assignees
No one assigned
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sftim @k8s-ci-robot @chalin @network-charles @SayakMukhopadhyay