Fix: Button Text Not Displayed in Selected Language for "Tell Your Story" Button in Case Study Tab #49593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/web-development
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
/lgtm
Deploy Preview: https://deploy-preview-49593--kubernetes-io-main-staging.netlify.app/case-studies/
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: dd346ef330c6cd518c48dfd2455f92987215aedf
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug : When switching to a different language on the website, most text updates correctly. However, the text on the "Tell Your Story" button in the Case Study tab does not switch to the selected language. This issue may confuse users who speak only the selected language, potentially leading to missed feedback.
Fix: This PR ensures that the "Tell Your Story" button in the Case Study tab correctly displays the text in the selected language, providing a consistent experience for users in any language.
closes #37501
I already Opend a PR #48671 for this 2 moths ago but mistakenly closed it @sftim , please let me know if there is more changes needed thanks