Skip to content

[KEP-3973]: document .status.terminatingReplicas enabled by DeploymentPodReplacementPolicy feature#49896

Merged
k8s-ci-robot merged 1 commit intokubernetes:dev-1.33from
atiratree:pod-replacement-policy-docs
Mar 27, 2025
Merged

[KEP-3973]: document .status.terminatingReplicas enabled by DeploymentPodReplacementPolicy feature#49896
k8s-ci-robot merged 1 commit intokubernetes:dev-1.33from
atiratree:pod-replacement-policy-docs

Conversation

@atiratree
Copy link
Member

@atiratree atiratree commented Feb 25, 2025 •
edited
Loading

Description

Document .status.terminatingReplicas enabled by DeploymentPodReplacementPolicy feature (replaces #48370)

Issue

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Feb 25, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 25, 2025
@atiratree atiratree mentioned this pull request Feb 25, 2025
Closed
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 25, 2025
@netlify
Copy link

netlify bot commented Feb 25, 2025 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit def6c59
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/67e4251cf8f82a0008bc12fe

This was referenced Feb 25, 2025
Draft
Open
@netlify
Copy link

netlify bot commented Feb 25, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit def6c59
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67e4251df194200008ce9863
😎 Deploy Preview https://deploy-preview-49896--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@atiratree atiratree force-pushed the pod-replacement-policy-docs branch from aff1ce1 to d9c85f5 Compare March 25, 2025 13:47
@atiratree atiratree changed the title [KEP-3973]: docs for DeploymentPodReplacementPolicy [KEP-3973]: document .status.terminatingReplicas enabled by DeploymentPodReplacementPolicy feature Mar 25, 2025
@atiratree
Copy link
Member Author

atiratree commented Mar 25, 2025

We have managed to add a new status field .status.terminatingReplicas to Deployments and ReplicaSets, but the main feature is still under API review.

I have updated this PR to reflect that.

@atiratree
Copy link
Member Author

atiratree commented Mar 25, 2025

/assign @soltysh

tengqm
tengqm reviewed Mar 26, 2025
View reviewed changes
soltysh
soltysh approved these changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit from Qiming Teng and then this is good
from sig-apps pov

@atiratree atiratree force-pushed the pod-replacement-policy-docs branch from d9c85f5 to def6c59 Compare March 26, 2025 16:02
@tengqm
Copy link
Contributor

tengqm commented Mar 26, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2025
@windsonsea
Copy link
Member

windsonsea commented Mar 27, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 27, 2025

LGTM label has been added.

DetailsGit tree hash: a90d90cf9d19a923dcdff979b8a8ebff5ab614f8

@k8s-ci-robot k8s-ci-robot merged commit 0fe29ac into kubernetes:dev-1.33 Mar 27, 2025
6 checks passed
@atiratree atiratree mentioned this pull request Mar 27, 2025
Merged
@atiratree
Copy link
Member Author

atiratree commented Mar 27, 2025

last minute followup #50287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tengqm tengqm tengqm left review comments

@drewhagen drewhagen Awaiting requested review from drewhagen

@windsonsea windsonsea Awaiting requested review from windsonsea

+1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

@windsonsea windsonsea

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@atiratree @tengqm @k8s-ci-robot @windsonsea @soltysh