-
Notifications
You must be signed in to change notification settings - Fork 14.8k
Update Hugo to v0.145.0 and fix Resource.Err deprecation #50100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
958ed25
to
2277060
Compare
Signed-off-by: The Anh Nguyen <[email protected]>
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @natalisucks, @divya-mohan0209 can you check my PR? |
The latest release of Docsy (0.11.0) has official support upto 0.136.1 (see). Although the HEAD has been updated to a pretty recent version of Hugo, it should be noted that we are multiple versions of Docsy behind. As such, I don't have a lot of confidence about whether a newer version of Hugo will remain compatible as we upgrade towards the latest Docsy. |
/hold given the valid-looking concern in #50100 (comment) |
/area web-development |
Hi @SayakMukhopadhyay, do you have any idea? |
I'm sorry, idea of what exactly? Our suggestion would be to downgrade your Hugo version if you are using a local build or alternatively, use a container build, which comes with its own Hugo. |
Docsy's 0.11.1 (unreleased) has support Hugo 0.145.0 (https://github.com/google/docsy/blob/3b8482557b530533e627292638a18b42da783540/package.json#L44C5-L44C33), I think we can wait until it's released and then update this K8s website docsy to 0.11.1? |
Updating the website to the latest Docsy is non trivial process since it has a lot of customisations. We are in the process of upgrading one minor version at a time. See #49430 for some background on our attempt to migrate to 0.7.0 which also has links to some other issues and PRs that might be helpful. Anyway, if you would like to assist in this upgrade, help is welcome. |
Thank you for the context on the Docsy upgrade challenges. I understand that the customizations make this a complex process requiring an incremental approach. I've reviewed #49430 and would happily assist with the upgrade efforts. |
If you are in the kubernetes slack, give me a mention in the #sig-docs channel (same name as here) and we can discuss in detail there. |
I did |
@SayakMukhopadhyay @ntheanh201 do we have any update on this after you discussed detail on slack?! |
@iamNoah1 We will still need to work towards upgrading the Docsy version of the website first before we can get this PR merged. |
Description
This PR updates the website to use Hugo v0.145.0 (from v0.133.0) and fixes compatibility issues with the deprecated Resource.Err field.
See: https://gohugo.io/functions/go-template/try
Issue
When running with Hugo v0.141.0+, the build fails with the error:
"can't evaluate field Err in type resource.Resource: Resource.Err was removed in Hugo v0.141.0 and replaced with a new try keyword"
Closes: #49836