Skip to content

Add active members as docs-id reviewers #50236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

girikuncoro
Copy link
Contributor

@girikuncoro girikuncoro commented Mar 26, 2025

Description

Add active members as docs-id reviewers to help with the reviewing PRs to docs-id as more contributions are coming in.

/cc @sftim @irvifa

@k8s-ci-robot k8s-ci-robot requested a review from sftim March 26, 2025 01:06
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 26, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sftim for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Mar 26, 2025
@k8s-ci-robot
Copy link
Contributor

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the kubernetes org. You can then trigger verification by writing /verify-owners in a comment.

  • enchant3dmango
    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.
  • ridwanbejo
    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.
  • za
    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.

Copy link

netlify bot commented Mar 26, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 8cbd97f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67e3531e6a1bfa0008aaa65e
😎 Deploy Preview https://deploy-preview-50236--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@divya-mohan0209
Copy link
Contributor

Hi @girikuncoro, thanks for the PR. Please ensure you secure membership for all three members listed here within the K8s org before we proceed to add them to the OWNERS file.

@girikuncoro
Copy link
Contributor Author

girikuncoro commented Mar 27, 2025

thanks @divya-mohan0209 , this is what we are currently doing, will update the progress here

first member: kubernetes/org#5488
will follow up for the rest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants