Skip to content

update docker image (busybox) #50360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

abentele
Copy link

@abentele abentele commented Apr 1, 2025

Description

Updated the docker image radial/busyboxplus:curl to busybox:1.37

Don't know if it's suitable to run the nslookup command. Therefore please check it during the review and maybe adjust it to solve the issue described below.

Issue

The docker image radial/busyboxplus:curl was not updated for long time. Therefore when running the command mentioned in the tutorial, I get this error (with RKE2, server version v1.31.6+rke2r1):

ErrImagePull (failed to pull and unpack image "docker.io/radial/busyboxplus:curl": failed to get converter for "docker.io/radial/busyboxplus:curl": Pulling Schema 1 images have been deprecated and disabled by default since containerd v2.0. As a workaround you may set an environment variable `CONTAINERD_ENABLE_DEPRECATED_PULL_SCHEMA_1_IMAGE=1`, but this will be completely removed in containerd v2.1.)

@k8s-ci-robot k8s-ci-robot requested a review from lavalamp April 1, 2025 13:21
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rayandas for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from thockin April 1, 2025 13:21
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 1, 2025
Copy link

netlify bot commented Apr 1, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 06a9106
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67ebe84d4316f100080ea498
😎 Deploy Preview https://deploy-preview-50360--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@jayeshmahajan jayeshmahajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking a time in finding this and raising PR.

@@ -241,7 +241,7 @@ or [Installing CoreDNS](/docs/tasks/administer-cluster/coredns/#installing-cored
Let's run another curl application to test this:

```shell
kubectl run curl --image=radial/busyboxplus:curl -i --tty --rm
kubectl run -i --tty --image busybox:1.37 dns-test --restart=Never --rm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why to even hardcode the version. May be just go with this to avoid future version fix.

kubectl run -i --tty --image busybox dns-test --restart=Never --rm

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a general question: you can save yourself the hassle of updating the versions, but it may cause problems in the future if the image is changed. In a tutorial it's maybe better without a version. Is there a general rule how it should be implemented on this website?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants