Skip to content

fix grammar error in server-side-apply #50469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix grammar error in server-side-apply #50469

wants to merge 1 commit into from

Conversation

BenTheElder
Copy link
Member

Description

"can accepts" doesn't make sense, it should be "can accept".

Issue

Closes: #

@k8s-ci-robot k8s-ci-robot requested a review from lavalamp April 11, 2025 19:08
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Apr 11, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 11, 2025
@jpbetz
Copy link
Contributor

jpbetz commented Apr 11, 2025

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a90b072e2b9a62bcb65b75d09d0ae98f8e92119f

@netlify Netlify
Copy link

netlify bot commented Apr 11, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 0f89a2b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6801b057f6e2cd00085f215d
😎 Deploy Preview https://deploy-preview-50469--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

BenTheElder
BenTheElder commented Apr 11, 2025
View reviewed changes
content/en/docs/reference/using-api/server-side-apply.md Outdated
@@ -572,7 +572,7 @@ kubectl apply --server-side --field-manager=my-manager [--dry-run=server]

## API implementation

The `PATCH` verb for a resource that supports Server-Side Apply can accepts the
The `PATCH` verb for a resource that supports Server-Side Apply can accept the
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it might make more sense to say:

Suggested change
The `PATCH` verb for a resource that supports Server-Side Apply can accept the
The `PATCH` verb for a resource that supports Server-Side Apply accepts the

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe:

-The `PATCH` verb for a resource that supports Server-Side Apply can accept the
+The `PATCH` verb (for an object that supports Server-Side Apply) accepts the

All resources that support SSA are also objects.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpbetz any concerns?, pushed this suggestion.

@justinsb
Copy link
Member

justinsb commented Apr 11, 2025 •
edited
Loading

Maybe accepts is referring to the resource, not the kind?

@BenTheElder
Copy link
Member Author

BenTheElder commented Apr 18, 2025 •
edited
Loading

Maybe accepts is referring to the resource, not the kind?

I think it's clearly meant to refer to the HTTP verb (really the api server handler for the verb) accepting the header.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2025
@k8s-ci-robot k8s-ci-robot requested a review from jpbetz April 18, 2025 01:52
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jayeshmahajan, jpbetz
Once this PR has been reviewed and has the lgtm label, please assign dipesh-rawat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmktfy lmktfy lmktfy left review comments

@jayeshmahajan jayeshmahajan jayeshmahajan approved these changes

@lavalamp lavalamp Awaiting requested review from lavalamp

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@jpbetz jpbetz Awaiting requested review from jpbetz

Assignees

@jpbetz jpbetz

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BenTheElder @jpbetz @k8s-ci-robot @justinsb @jayeshmahajan @lmktfy