-
Notifications
You must be signed in to change notification settings - Fork 14.8k
[fa] Persian/Farsi support for the Kubernetes Website #50762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
+ Adds Persian as a dropdown option + Translates the entire main page + Translates the most important parts of the i8 file + Adds a structure for essential pages that need to be translated next + Takes a stab at the README.md in the Farsi folder for next contributors
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @frozenprocess! |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the pull request.
/hold
We can merge this once all of:
- it meets minimum requirements for launching a new localization
- the main branch has at least MVP support for right-to-left writing systems
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice this page is in the wrong language (English).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, some of the pages are in English since I'm trying to have the barebone version of the website available for anyone else who is interested to join in and start to translate. I find it easier if you don't have to worry about how Hugo works and just translate sentences.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lmktfy this was a huge help, somehow I missed it before :D I'll try to rebase my PR to meet that , and I will get rid of English pages that I put there as placeholder for links to work!
it meets minimum requirements for launching a new localization
The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the kubernetes org. You can then trigger verification by writing
|
Description
This commit adds the Persian/Farsi language to the docs.
Issue
#47142
#22730
Closes: #47142