Skip to content

Upgrade mysql image version to allow multi-arch env #50822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

serut
Copy link

@serut serut commented May 7, 2025

The Run a Single-Instance Stateful Application tutorial uses an old version of mysql that does not provide an ARM version of the image.

I've upgraded the version of the image used as this is as simple as that to make it work on newest macbook pro.

This is an effort of #45822

Without this :

➜  k8s kubectl describe pods -l app=mysql | grep image
  Normal   Pulling    3s    kubelet            Pulling image "mysql:5.6"
  Warning  Failed     1s    kubelet            Failed to pull image "mysql:5.6": no matching manifest for linux/arm64/v8 in the manifest list entries

With this :

➜  k8s kubectl describe pods -l app=mysql | grep image
  Normal  Pulling    70s   kubelet            Pulling image "mysql:9"
  Normal  Pulled     69s   kubelet            Successfully pulled image "mysql:9" in 1.059s (1.059s including waiting). Image size: 876227616 bytes.

The rest of the service declaration is fine:

➜  k8s kubectl get pods -l app=mysql
NAME                     READY   STATUS    RESTARTS      AGE
mysql-6c7c777b75-vr7lt   1/1     Running   0             29s

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 7, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign divya-mohan0209 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/localization General issues or PRs related to localization language/bn Issues or PRs related to Bengali language labels May 7, 2025
@k8s-ci-robot k8s-ci-robot requested review from Arhell and asem-hamid May 7, 2025 10:31
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language language/fr Issues or PRs related to French language labels May 7, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @serut!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added language/hi Issues or PRs related to Hindi language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/ru Issues or PRs related to Russian language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 7, 2025
Copy link

netlify bot commented May 7, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 90fc4df
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/681b3676f74b1a00087c47c2
😎 Deploy Preview https://deploy-preview-50822--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stmcginnis
Copy link
Contributor

We typically only allow updating one language at a time. That said, this is not a language change, but a mechanical one. So, at least in my opinion, I think this is fine.

Good to update to a newer version anyway. Confirmed this version is a multiarch image:

crane manifest mysql:9 | jq '.manifests[].platform'
{
  "architecture": "amd64",
  "os": "linux"
}
{
  "architecture": "unknown",
  "os": "unknown"
}
{
  "architecture": "arm64",
  "os": "linux",
  "variant": "v8"
}
{
  "architecture": "unknown",
  "os": "unknown"
}

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 874726434d16fa66d335751ace7bb7a461331650

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/bn Issues or PRs related to Bengali language language/en Issues or PRs related to English language language/fr Issues or PRs related to French language language/hi Issues or PRs related to Hindi language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/ru Issues or PRs related to Russian language language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants