-
Notifications
You must be signed in to change notification settings - Fork 14.8k
Upgrade mysql image version to allow multi-arch env #50822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
fix yml fox version
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @serut! |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
We typically only allow updating one language at a time. That said, this is not a language change, but a mechanical one. So, at least in my opinion, I think this is fine. Good to update to a newer version anyway. Confirmed this version is a multiarch image:
{
"architecture": "amd64",
"os": "linux"
}
{
"architecture": "unknown",
"os": "unknown"
}
{
"architecture": "arm64",
"os": "linux",
"variant": "v8"
}
{
"architecture": "unknown",
"os": "unknown"
} /lgtm |
LGTM label has been added. Git tree hash: 874726434d16fa66d335751ace7bb7a461331650
|
The
Run a Single-Instance Stateful Application
tutorial uses an old version of mysql that does not provide an ARM version of the image.I've upgraded the version of the image used as this is as simple as that to make it work on newest macbook pro.
This is an effort of #45822
Without this :
With this :
The rest of the service declaration is fine: