Skip to content

KEP-3619: Fix the directory name for KEP-3619 beta blog post #50823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

everpeace
Copy link
Contributor

@everpeace everpeace commented May 7, 2025

Description

#50792 set its publish date and remove draft: true from the front matter. However, the directory name still contains XXXX-XX-XX. This PR updates the directory name.

Although I'm not sure about it, I expected this PR will NOT change its already published blog URL: https://kubernetes.io/blog/2025/05/06/kubernetes-v1-33-fine-grained-supplementalgroups-control-beta/.

Updated: Preview URL shows it does not seem to be changed.
https://deploy-preview-50823--kubernetes-io-main-staging.netlify.app/blog/2025/05/06/kubernetes-v1-33-fine-grained-supplementalgroups-control-beta/

Issue

ref: https://github.com/kubernetes/website/pull/50792/files#r2077399519

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 7, 2025
@k8s-ci-robot k8s-ci-robot requested a review from Gauravpadam May 7, 2025 11:16
@k8s-ci-robot k8s-ci-robot added the area/blog Issues or PRs related to the Kubernetes Blog subproject label May 7, 2025
@k8s-ci-robot k8s-ci-robot requested a review from lmktfy May 7, 2025 11:16
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 7, 2025
Copy link

netlify bot commented May 7, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 3e43a62
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/681b41137736d80008f476a3
😎 Deploy Preview https://deploy-preview-50823--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@rytswd rytswd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this earlier... Thanks for the catch!
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rytswd
Once this PR has been reviewed and has the lgtm label, please assign natalisucks for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 34378ffe43ae1d1836788ba607173697d4993863

@rytswd
Copy link
Member

rytswd commented May 7, 2025

My understanding is that this change is more for the blog markdown sanity, which makes it easy for SIG Docs Blog team to manage the old articles easily. As you pointed out with the preview build, I do not think this would actually affect the already-published blog 👍

@everpeace
Copy link
Contributor Author

/assign @natalisucks

@rytswd
Copy link
Member

rytswd commented May 7, 2025

CC @lmktfy

@everpeace everpeace changed the title KEP-3619: Change the directory name for KEP-3619 beta blog post KEP-3619: Fix the directory name for KEP-3619 beta blog post May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants