Skip to content

Add API deprecation terminology guidance#55693

Open
p1930n wants to merge 1 commit intokubernetes:mainfrom
p1930n:clarify-api-deprecation-terms
Open

Add API deprecation terminology guidance#55693
p1930n wants to merge 1 commit intokubernetes:mainfrom
p1930n:clarify-api-deprecation-terms

Conversation

@p1930n
Copy link
Copy Markdown
Contributor

@p1930n p1930n commented May 6, 2026

Summary

  • add style guide guidance for API change terminology
  • distinguish deprecated, no longer served, and removed
  • discourage using obsolete for Kubernetes APIs

Issue

Fixes #28690

Validation

  • git diff --check

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign reylejano for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from lmktfy May 6, 2026 13:34
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label May 6, 2026
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 6, 2026
@p1930n p1930n force-pushed the clarify-api-deprecation-terms branch from f2a9494 to 4c52548 Compare May 6, 2026 14:35
@p1930n
Copy link
Copy Markdown
Contributor Author

p1930n commented May 6, 2026

Local validation completed successfully:

  • Built the deploy preview locally with Hugo v0.133.0 using the same preview settings as Netlify.
  • Ran npx -y pagefind --site public after the Hugo build.

Both steps completed successfully locally. The Netlify deploy preview has failed twice after about 9m40s, but the GitHub checks only report Deploy failed and the Netlify build logs are not publicly accessible from my side.

Could someone with Netlify access check the build log or retry the deploy?

@p1930n
Copy link
Copy Markdown
Contributor Author

p1930n commented May 6, 2026

Additional context: this Netlify failure does not appear isolated to this PR. I checked nearby PRs and saw the same external deploy failure pattern on #55680 and #55690: deploy/netlify fails and the Header rules / Pages changed / Redirect rules checks all report Deploy failed, with an empty public Netlify summary.

Other nearby PRs such as #55692 have successful Netlify deploy previews, so the failing cases still need the private Netlify build log to identify the actual failing step.

@p1930n p1930n marked this pull request as ready for review May 7, 2026 05:02
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 7, 2026
@pacoxu
Copy link
Copy Markdown
Member

pacoxu commented May 7, 2026

A force push(after rebase the latest main branch) will trigger a retest, which may help.

Signed-off-by: p1930n <p1930n_official@outlook.com>
@p1930n p1930n force-pushed the clarify-api-deprecation-terms branch from 4c52548 to bc19b10 Compare May 7, 2026 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add distinction for "deprecated" vs "removed" API versions in the style guide

3 participants