Fix navbar hover state on scroll#55700
Open
p1930n wants to merge 2 commits intokubernetes:mainfrom
Open
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/web-development
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
p1930n
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
When the homepage navbar switches to
.navbar-bg-onscroll, the base link color becomes dark gray. The previous selector only applied the hover color when an element was both hovered and focused, so plain hover could fall back to the dark navbar hover styling and become hard to read against the white scrolled navbar.Fixes #54938
Validation
git diff --checkAI disclosure
This PR was assisted by Codex / AI tooling
I completed the overall direction and implementation plan myself. The initial code were made by an AI agent, then I reviewed and modified the remaining issues. The changes were reviewed again by the AI agent, followed by another review from me with additional feedback. A later revision was made by a sub-agent
The final PR description and commit content were drafted with AI assistance and reviewed by me. I reviewed all submitted changes and take responsibility for the final result