Skip to content

use the SSA client to install the operators#117

Merged
metlos merged 1 commit into
kubesaw:masterfrom
metlos:ssa-install-operator
Jun 9, 2025
Merged

use the SSA client to install the operators#117
metlos merged 1 commit into
kubesaw:masterfrom
metlos:ssa-install-operator

Conversation

@metlos

@metlos metlos commented May 27, 2025

Copy link
Copy Markdown
Contributor

$TITLE

@MatousJobanek MatousJobanek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but before merging it, could you please create a paired PR in the toolchain-e2e repo (with the same branch) to make sure that everything will work as expected? thanks

@rsoaresd rsoaresd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@metlos

metlos commented Jun 9, 2025

Copy link
Copy Markdown
Contributor Author

codeready-toolchain/toolchain-e2e#1155 has passed, so this can be merged.

@metlos metlos force-pushed the ssa-install-operator branch from e450744 to d704639 Compare June 9, 2025 09:58
@metlos metlos merged commit 6c22f5f into kubesaw:master Jun 9, 2025
5 of 8 checks passed
@codecov

codecov Bot commented Jun 9, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 63.63636% with 8 lines in your changes missing coverage. Please review.

Project coverage is 70.54%. Comparing base (16d9570) to head (d704639).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/cmd/adm/install_operator.go 63.63% 2 Missing and 6 partials ⚠️

❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
+ Coverage   70.49%   70.54%   +0.05%     
==========================================
  Files          56       56              
  Lines        4016     4013       -3     
==========================================
  Hits         2831     2831              
+ Misses        961      958       -3     
  Partials      224      224              
Files with missing lines Coverage Δ
pkg/utils/util.go 77.35% <ø> (ø)
pkg/cmd/adm/install_operator.go 76.06% <63.63%> (+1.19%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants