Fixing evaluation logic in C-0044 and execution safety in C-0048 #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben <[email protected]>
amitschendel
previously approved these changes
Jan 30, 2025
Signed-off-by: Ben <[email protected]>
Signed-off-by: Ben Hirschberg <[email protected]>
Signed-off-by: Ben <[email protected]>
…ry into fix/volumes
Signed-off-by: Ben <[email protected]>
amitschendel
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the validation expressions in the
policy.yamlfiles for controlsC-0044andC-0048. The changes aim to simplify and improve the accuracy of the validation logic.Fixes #58 and #59
Improvements to validation expressions:
controls/C-0044/policy.yaml: Updated the expressions to use theexistsmethod for checking container ports with host ports, improving readability and accuracy.controls/C-0048/policy.yaml: Modified the expressions to include a check for the presence of volumes before validating hostPath mounts, ensuring the logic handles cases where volumes may not be present.