Add Controls C-0268, C-0269, C-0270, C-0271 to allow for more fine granular testing of cpu/mem limits/requests being set #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Pöhler <[email protected]>
Signed-off-by: Florian Pöhler <[email protected]>
Signed-off-by: Florian Pöhler <[email protected]>
Signed-off-by: Florian Pöhler <[email protected]>
poehlerflorian
force-pushed
the
feature/add-controls-c-0268--c-0271
branch
from
25658ee to
3a84f56
Compare
|
Thanks @poehlerflorian for the contribution, I will look into it a bit later! |
Signed-off-by: Florian Pöhler <[email protected]>
poehlerflorian
force-pushed
the
feature/add-controls-c-0268--c-0271
branch
from
3a84f56 to
8a3a894
Compare
slashben
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is only possible to check for cpu/memory requests and limits. Since it is not recommended to set cpu limits when cpu requests are correctly set (see this post e.g.) the controls C-0004 and C-0050 are being split up into C-0268 to C-0271 like it has already been done in the regolibrary (kubescape/regolibrary#594).
Also the control C-0050 contained a bug where cpu requests were compared to the configured max/min cpu limit.