Fixing CronJob support accross all controls #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben <[email protected]>
matthyx
previously approved these changes
Mar 12, 2025
- Modify memory resource validation to use `quantity().asInteger()` for correct parsing - Update test cases to use Kubernetes memory unit suffixes (Mi, Gi, Ki) - Expand memory resource configuration range in default and basic control configurations - Ensure consistent memory resource validation across Pod, Workload, and CronJob resources Signed-off-by: Ben <[email protected]>
matthyx
previously approved these changes
Mar 12, 2025
Signed-off-by: Ben <[email protected]>
Signed-off-by: Ben <[email protected]>
matthyx
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the
CronJobsupport across all controls that already supportedCronJobs.The main changes involve updating the expressions for
CronJobresources to ensure they correctly reference thetemplate.specpath. Additionally, new test cases forCronJobresources have been added to thetests.jsonfiles.This fixes #62
Policy Expression Updates:
policy.yamlfiles for multiple controls to correctly referenceobject.spec.jobTemplate.spec.template.specforCronJobresources. This change ensures that the policies are correctly applied to theCronJobresources. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]Test Case Additions:
tests.jsonfiles forCronJobresources to validate the updated policy expressions. These tests ensure thatCronJobresources with specific configurations are correctly allowed or blocked according to the policies. [1] [2] [3] [4]