Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added unit tests for cloudmetadata, aws account id extraction #119

Merged
merged 4 commits into from
Jan 30, 2025

Conversation

amirmalka
Copy link
Contributor

@amirmalka amirmalka commented Jan 30, 2025

Changes:

  • Unit tests for cloud metadata package
  • Fix GCP account id extraction
  • Add method to extract AWS account id from aws-auth configmap

Signed-off-by: Amir Malka <[email protected]>
Copy link

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

1 similar comment
Copy link

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

Copy link

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: failure

@amirmalka amirmalka changed the title added unit tests for cloudmetadata added unit tests for cloudmetadata, aws account id extraction Jan 30, 2025
Copy link

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

Copy link

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

2 similar comments
Copy link

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

Copy link

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

@amirmalka amirmalka merged commit 9765191 into main Jan 30, 2025
7 of 8 checks passed
@matthyx matthyx deleted the test-cloudmetadata branch February 4, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants