Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused statuses #125

Closed
wants to merge 1 commit into from
Closed

remove unused statuses #125

wants to merge 1 commit into from

Conversation

amirmalka
Copy link
Contributor

No description provided.

@amirmalka
remove unused statuses
9c7dfaf 
Signed-off-by: Amir Malka <[email protected]>
@amirmalka amirmalka requested a review from matthyx February 23, 2025 08:53
@matthyx
Copy link
Contributor

matthyx commented Feb 23, 2025

Did you check they're unused everywhere? Otherwise we mark as deprecated...

@github-actions GitHub Actions
Copy link

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

@matthyx
Copy link
Contributor

matthyx commented Feb 24, 2025

see https://github.com/kubescape/kubevuln/blob/275ca317ab82efea7ccc42b343888341d61e45b2/adapters/v1/syft.go#L159

@matthyx
Copy link
Contributor

matthyx commented Feb 24, 2025

statuses are not unused

@matthyx matthyx closed this Feb 24, 2025
@amirmalka
Copy link
Contributor Author

Thanks, I missed it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthyx matthyx Awaiting requested review from matthyx

Assignees

@amitschendel amitschendel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amirmalka @matthyx @amitschendel