fix score calculation for framework with all controls in status irrelevant #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirmalka
changed the title
amirmalka
force-pushed
the
fix-all-controls-irrelevant
branch
2 times, most recently
from
0575149 to
a04d1aa
Compare
…evant Signed-off-by: Amir Malka <[email protected]>
amirmalka
force-pushed
the
fix-all-controls-irrelevant
branch
from
a04d1aa to
d4c141c
Compare
jnathangreeg
approved these changes
Mar 3, 2025
matthyx
approved these changes
Mar 3, 2025
amirmalka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case were we have a framework where all controls were irrelevant - the ScoreUtil would finish with error (since wcsScore was 0) - as a result also compliance score for other frameworks and for the report would not be calculated.
As part of the fix, we check - if the score was 0 + all controls in framework are in status (passed-irrelevant) - we set the score of the framework to 100% (as this is also true for compliance score of a single control in status irrelevant).