Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix score calculation for framework with all controls in status irrelevant #158

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

amirmalka
Copy link
Contributor

@amirmalka amirmalka commented Mar 3, 2025

In case were we have a framework where all controls were irrelevant - the ScoreUtil would finish with error (since wcsScore was 0) - as a result also compliance score for other frameworks and for the report would not be calculated.

As part of the fix, we check - if the score was 0 + all controls in framework are in status (passed-irrelevant) - we set the score of the framework to 100% (as this is also true for compliance score of a single control in status irrelevant).

@amirmalka amirmalka changed the title fix score calculation for framework with all controls in status irrel… fix score calculation for framework with all controls in status irrellevant Mar 3, 2025
@amirmalka amirmalka force-pushed the fix-all-controls-irrelevant branch 2 times, most recently from 0575149 to a04d1aa Compare March 3, 2025 11:30
@amirmalka amirmalka force-pushed the fix-all-controls-irrelevant branch from a04d1aa to d4c141c Compare March 3, 2025 11:31
@amirmalka amirmalka changed the title fix score calculation for framework with all controls in status irrellevant fix score calculation for framework with all controls in status irrelevant Mar 3, 2025
@amirmalka amirmalka merged commit c397820 into main Mar 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants