Bump to go 1.25 #1493
Open
Bump to go 1.25 #1493
+40
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masaru Hoshi <[email protected]>
nthtrung09it
approved these changes
Jan 30, 2026
nthtrung09it
left a comment
nthtrung09it
left a comment
There was a problem hiding this comment.
LGTM. Go 1.25 compat changes are correct — all callers of the renamed functions verified. The test-coverage target runs tests 3x which could be optimized to capture coverage data in a single pass, but it's functional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Masaru Hoshi [email protected]
Description
Added comprehensive test coverage tooling:
Testing
Total coverage: 38.9% of statements
35 packages with tests
3 packages with 100% coverage:
Areas needing attention (lowest coverage):