fix: accept large numeric config values in TestWorkflow CRDs - #8076
Open
dejanzele wants to merge 1 commit into
Open
fix: accept large numeric config values in TestWorkflow CRDs#8076dejanzele wants to merge 1 commit into
dejanzele wants to merge 1 commit into
Conversation
Contributor
Greptile SummaryThe PR introduces a raw-text
Confidence Score: 5/5The PR appears safe to merge, with no concrete production or compatibility defects identified in the changed paths. Large numeric configuration values are preserved through CRD decoding, mapping, expression resolution, and API serialization, while older IntOrString clients receive out-of-range values as strings. Important Files Changed
Reviews (1): Last reviewed commit: "fix: accept large numeric config values ..." | Re-trigger Greptile |
This was referenced Aug 6, 2026
courageousillumination
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A TestWorkflow with a numeric
config.defaultabove the int32 range, for example873760302410822, breaks every client that reads the CRD withintstr.IntOrString. The whole informer list fails to decode, the agent stops the sync of all workflows, and the UI shows none. (TKC-6402)How:
config.default,config.example, and theconfigmaps on template refs, steps, cron jobs, and execution requests) now use a newConfigValuetype. The type keeps the raw scalar text, so a number of any size decodes without loss. The CRD schema staysx-kubernetes-int-or-string.ConfigValueemits a JSON number only when the value is a canonical integer in the int32 range. A larger number becomes a string, so an older client that still decodes withintstr.IntOrStringdoes not fail on data from a new agent.clonehelper in the expressions engine now keeps the named type of a string value, so template resolution can write the result back into amap[string]ConfigValue.Resource limits and requests,
countandmaxCount, and the serviceportstill useintstr.IntOrStringand have the same failure mode. This change does not cover them.