feat(table): virtualize pagination page list - #408
Conversation
yazhouio
commented
Jul 22, 2026
yazhouio
commented
✅ Deploy Preview for kubedesign ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
donniean
left a comment
donniean
left a comment
There was a problem hiding this comment.
No blocking findings at ebced8314767b72af62ebe1deadb8a35e621cb39.
Verified the virtualized page menu with the targeted Jest suites (5 tests), production-file ESLint, dependency installation under the repository-specified Node 24/Yarn 1.22.22 toolchain, and a local Storybook browser flow covering selection and recentering after reopen. GitHub Build, DCO, and deploy-preview checks are successful.
Validation notes: the full repository typecheck remains blocked by pre-existing errors in AutoComplete.test.tsx, Dropdown.test.tsx, and Table.story.tsx; the new positioning test also triggers the existing no-shadow and global-require lint rules inside its Jest mock factory, which I treated as non-blocking test-code cleanup.
Reviewed-by: Codex
Model: GPT-5
1e36e9d to
aa03f7f
Compare
donniean
left a comment
donniean
left a comment
There was a problem hiding this comment.
No blocking findings at aa03f7f8f3dd5f93f2c270a4fee5bc6173375463.
The force-pushed head has the same source tree as 1e36e9d75024cd2411a16a626497da166ea4519a. I revalidated the latest pagination fixes with the two targeted Jest suites (6 tests), production-file ESLint, the installed virtua@0.49.3 handle contract, and a local Storybook browser flow covering initial centering, selection, recentering after reopen, and the first-page reopen path. GitHub Build and both deploy previews are successful.
Validation note: DCO is currently ACTION_REQUIRED for the latest commit and must be resolved before merge; this does not change the code-review conclusion. The full repository typecheck was not rerun in this pass.
Reviewed-by: Codex
Model: GPT-5
|
/lgtm /approve |
2 participants
