Skip to content

Conversation

@CYS158
Copy link
Contributor

@CYS158 CYS158 commented Dec 26, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

none

Additional documentation, usage docs, etc.:


@gemini-code-assist
Copy link

Summary of Changes

Hello @CYS158, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求旨在通过增加对Rocky Linux 9.7和10.1操作系统的兼容性,以及引入对Kubernetes v1.34.x版本的支持,来扩展系统的部署灵活性和兼容性。这些更改确保了用户可以在更广泛的环境中部署和管理Kubernetes集群。

Highlights

  • 支持Rocky Linux 9.7/10.1: 此拉取请求增加了对Rocky Linux 9.7和10.1操作系统的支持,扩展了可部署环境的兼容性。
  • 支持Kubernetes v1.34.x: 引入了对最新Kubernetes v1.34.x版本的支持,包括其默认配置和相关组件版本。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@kubesphere-prow kubesphere-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 26, 2025
@sonarqubecloud
Copy link

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

这个 PR 增加了对 Rocky Linux 的支持,并为未来的 Kubernetes v1.34.x 版本添加了新的配置文件。整体来看,变更主要是添加了新的配置。我发现了一些问题,包括使用了不存在的组件版本,以及在一个配置文件中存在硬编码版本号导致的可维护性问题。请查看具体的审查意见。

tag: 2.9.6-alpine
etcd:
# etcd binary
etcd_version: v3.5.25

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

指定的 etcd 版本 v3.5.25 似乎不存在。etcd v3.5.x 系列的最新稳定版本是 v3.5.14。使用一个不存在的版本将导致安装过程中下载失败。请核实此版本号。

tag: "3.9"
# ========== cri ==========
# crictl binary
crictl_version: v1.33.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

指定的 crictl 版本 v1.33.0 似乎不存在。cri-tools 的最新发布版本是 v1.30.0。使用一个不存在的版本将导致下载失败。请检查该版本号。

tag: 2.9.6-alpine
etcd:
# etcd binary
etcd_version: v3.5.25

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

指定的 etcd 版本 v3.5.25 似乎不存在。etcd v3.5.x 系列的最新稳定版本是 v3.5.14。使用一个不存在的版本将导致安装过程中下载失败。请核实此版本号。

tag: "3.9"
# ========== cri ==========
# crictl binary
crictl_version: v1.33.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

指定的 crictl 版本 v1.33.0 似乎不存在。cri-tools 的最新发布版本是 v1.30.0。使用一个不存在的版本将导致下载失败。请检查该版本号。

Comment on lines +88 to +108
- docker.io/calico/apiserver:v3.28.2
- docker.io/calico/cni:v3.28.2
- docker.io/calico/ctl:v3.28.2
- docker.io/calico/csi:v3.28.2
- docker.io/calico/kube-controllers:v3.28.2
- docker.io/calico/node-driver-registrar:v3.28.2
- docker.io/calico/node:v3.28.2
- docker.io/calico/pod2daemon-flexvol:v3.28.2
- docker.io/calico/typha:v3.28.2
- docker.io/kubesphere/coredns:v1.12.1
- docker.io/kubesphere/k8s-dns-node-cache:1.24.0
- docker.io/kubesphere/kube-apiserver:{{ .kube_version }}
- docker.io/kubesphere/kube-controller-manager:{{ .kube_version }}
- docker.io/kubesphere/kube-proxy:{{ .kube_version }}
- docker.io/kubesphere/kube-scheduler:{{ .kube_version }}
- docker.io/kubesphere/pause:3.9
- docker.io/openebs/linux-utils:4.2.0
- docker.io/openebs/provisioner-localpv:4.2.0
- quay.io/tigera/operator:v1.34.5
- docker.io/library/haproxy:2.9.6-alpine
- docker.io/plndr/kube-vip:v0.7.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

image_manifests 中的镜像版本是硬编码的,而这些版本已在此文件的上文中定义为变量。这可能导致不一致和维护困难。为了提高可维护性,建议使用模板变量来引用这些版本,类似于 builtin/core/roles/defaults/vars/v1.34.yaml 文件中的做法。

    - docker.io/calico/apiserver:{{ .cni.calico_version }}
    - docker.io/calico/cni:{{ .cni.calico_version }}
    - docker.io/calico/ctl:{{ .cni.calico_version }}
    - docker.io/calico/csi:{{ .cni.calico_version }}
    - docker.io/calico/kube-controllers:{{ .cni.calico_version }}
    - docker.io/calico/node-driver-registrar:{{ .cni.calico_version }}
    - docker.io/calico/node:{{ .cni.calico_version }}
    - docker.io/calico/pod2daemon-flexvol:{{ .cni.calico_version }}
    - docker.io/calico/typha:{{ .cni.calico_version }}
    - docker.io/kubesphere/coredns:{{ .dns.dns_image.tag }}
    - docker.io/kubesphere/k8s-dns-node-cache:{{ .dns.dns_cache_image.tag }}
    - docker.io/kubesphere/kube-apiserver:{{ .kube_version }}
    - docker.io/kubesphere/kube-controller-manager:{{ .kube_version }}
    - docker.io/kubesphere/kube-proxy:{{ .kube_version }}
    - docker.io/kubesphere/kube-scheduler:{{ .kube_version }}
    - docker.io/kubesphere/pause:{{ .cri.sandbox_image.tag }}
    - docker.io/openebs/linux-utils:{{ .storage_class.local.linux_utils_image.tag }}
    - docker.io/openebs/provisioner-localpv:{{ .storage_class.local.provisioner_image.tag }}
    - quay.io/tigera/operator:v1.34.5
    - docker.io/library/haproxy:{{ .kubernetes.control_plane_endpoint.haproxy.image.tag }}
    - docker.io/plndr/kube-vip:{{ .kubernetes.control_plane_endpoint.kube_vip.image.tag }}

@redscholar
Copy link
Contributor

/approve
/lgtm

@kubesphere-prow kubesphere-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 26, 2025
@kubesphere-prow
Copy link

LGTM label has been added.

DetailsGit tree hash: 4e33d883b124d2b8b8a3c74f95e65ecaa189e0d9

@kubesphere-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CYS158, redscholar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubesphere-prow kubesphere-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-none and removed do-not-merge/release-note-label-needed labels Dec 26, 2025
@kubesphere-prow kubesphere-prow bot merged commit 3a7e6a7 into kubesphere:main Dec 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants