Skip to content

🐛 [scanner] fix: resolve persistent go vet and test build failures#18229

Closed
kubestellar-hive[bot] wants to merge 1 commit into
mainfrom
scanner/fix-18226
Closed

🐛 [scanner] fix: resolve persistent go vet and test build failures#18229
kubestellar-hive[bot] wants to merge 1 commit into
mainfrom
scanner/fix-18226

Conversation

@kubestellar-hive

@kubestellar-hive kubestellar-hive Bot commented Jun 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #18226
Fixes #18232

Resolves all persistent go vet and test build failures blocking PRs.

Changes

  1. pkg/agent/provider_helpers.go - Remove test var fakeExecCommandContext causing redeclaration errors
  2. pkg/agent/kube/testing.go - Add exported test setters (SetLookPathForTest, SetStatFileForTest, SetStandardToolCandidatesForTest)
  3. pkg/agent/server_http_test.go - Fix UpdateChecker usage to use updater.NewUpdateChecker()
  4. Multiple test files - Replace KubectlProxy struct literals with kube.NewTestKubectlProxy()
  5. pkg/settings/manager_validation_test.go - Fix Ciphertext type (string not []byte)
  6. pkg/api/transport - Add test helpers for unexported field access

This supersedes #18233 with the complete fix for all build failures.

Copilot AI review requested due to automatic review settings June 13, 2026 00:41
Copilot AI reviewed Jun 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Jun 13, 2026
@kubestellar-prow

kubestellar-prow Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify

netlify Bot commented Jun 13, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for kubestellarconsole ready!

Name Link
🔨 Latest commit ad1ebb1
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6a2cb709deacfa0008dfe5cd
😎 Deploy Preview https://deploy-preview-18229.console-deploy-preview.kubestellar.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

github-actions Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

👋 Hey @kubestellar-hive[bot] — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

This is an automated message.

@github-actions github-actions Bot added the ai-generated Pull request generated by AI label Jun 13, 2026
@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 13, 2026
🐛 [scanner] fix: resolve persistent go vet and test build failures in…
ad1ebb1 
… pkg/agent and pkg/api/handlers

- Remove unused fakeExecCommandContext var from pkg/agent/provider_helpers.go (redeclaration conflict)
- Export LookPath, StatFile, StandardToolCandidates in pkg/agent/kube/discovery.go for cross-package test access
- Fix UpdateChecker reference in pkg/agent/server_http_test.go (use updater.NewUpdateChecker)
- Replace KubectlProxy struct literals with kube.NewTestKubectlProxy() across all test files
- Fix Ciphertext type mismatch in pkg/settings/manager_validation_test.go (string not []byte)
- Add transport.TestRegisterClient, TestUnregisterClient, TestGetDoneChan, TestGetRegisterChan test helpers
- Update pkg/api/handlers/*_test.go to use transport test helpers instead of accessing unexported fields

Fixes #18232
Fixes #18226

Signed-off-by: GitHub Copilot <223556219+Copilot@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 13, 2026
@kubestellar-hive kubestellar-hive Bot mentioned this pull request Jun 13, 2026
Closed
@kubestellar-hive kubestellar-hive Bot changed the title 🐛 [scanner] fix: use synchronous token getter in tests to avoid async issues 🐛 [scanner] fix: resolve persistent go vet and test build failures Jun 13, 2026
@kubestellar-hive kubestellar-hive Bot mentioned this pull request Jun 13, 2026
Open
@kubestellar-hive

kubestellar-hive Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #18233 which was merged and addresses the same build failures.

@kubestellar-hive kubestellar-hive Bot closed this Jun 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

ai-generated Pull request generated by AI dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tier/2-standard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ci-maintainer] Persistent go vet/test build failures: pkg/agent, pkg/settings, pkg/api/transport 🐛 67 test failure(s) in Coverage Suite run #3748

2 participants