Skip to content

[scanner] fix: standardize spacing and refresh animation#18521

Merged
clubanderson merged 1 commit into
mainfrom
scanner/fix-18388
Jun 16, 2026
Merged

[scanner] fix: standardize spacing and refresh animation#18521
clubanderson merged 1 commit into
mainfrom
scanner/fix-18388

Conversation

@clubanderson

@clubanderson clubanderson commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Fixes #18388
Fixes #18393

Standardizes spacing values and ensures consistent refresh icon animation across components.

@clubanderson
[scanner] fix: standardize spacing values and refresh animation consi…
7c0d79e 
…stency

Signed-off-by: Andy Anderson <andy@clubanderson.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 16, 2026 22:13
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Jun 16, 2026
@kubestellar-prow

kubestellar-prow Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign eeshaansa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify

netlify Bot commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for kubestellarconsole ready!

Name Link
🔨 Latest commit 7c0d79e
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6a31ca8320a80c00088df422
😎 Deploy Preview https://deploy-preview-18521.console-deploy-preview.kubestellar.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added ai-generated Pull request generated by AI tier/2-standard labels Jun 16, 2026
@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 16, 2026
@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

👋 Hey @clubanderson — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

This is an automated message.

@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

🐝 Hi @clubanderson! I'm kubestellar-hive[bot], an automation bot for this repo.

Trusted users — org members and contributors with write access — can mention @kubestellar-hive in a comment to trigger repo automation.
On issues, that mention queues an automated fix attempt. On pull requests, it records extra context for existing automation.
This is not an interactive Q&A bot, so mentions should be treated as requests for automation rather than a conversation.

Automation may take a moment to start, and follow-up happens through workflow activity rather than chat replies.

@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Auto Test Generator

The following new files have no corresponding test file:

  • web/src/components/cards/HelmHistory.tsx

Please add tests or apply the needs-tests label to track this PR.

@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

✅ Test Coverage Check

All new source files in this PR have corresponding test files.

Checked web/src/hooks/ and web/src/components/ against origin/main.

Copilot AI reviewed Jun 16, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR targets two UI consistency concerns in the web console: aligning non-standard spacing to Tailwind’s spacing scale and making refresh/retry icon animation more consistent.

Changes:

  • Standardizes timeline line positioning by replacing left-[7px] with left-2 in two history/timeline components.
  • Adds a retry button refresh spin animation in the mission browser fetch error banner.

Note: frontend build/lint are expected to be validated by CI on the PR.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
web/src/components/missions/browser/EmptyState.tsx Adds retry refresh animation state and handler for the mission fetch error banner.
web/src/components/cards/workload-detection/ProwHistory.tsx Replaces a pixel-based left-[7px] with left-2 for consistent spacing.
web/src/components/cards/HelmHistory.tsx Replaces a pixel-based left-[7px] with left-2 for consistent spacing.

Comment thread web/src/components/missions/browser/EmptyState.tsx
Comment thread web/src/components/missions/browser/EmptyState.tsx
@clubanderson clubanderson merged commit 2da7bf4 into main Jun 16, 2026
45 of 53 checks passed
@kubestellar-prow kubestellar-prow Bot deleted the scanner/fix-18388 branch June 16, 2026 22:37
@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

❌ Post-Merge Verification: failed

Commit: 2da7bf424f7ad7971740de77239532d5f733b563
Specs run: Dashboard.spec.ts Missions.spec.ts mission-import.spec.ts smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/27652742175

@github-actions github-actions Bot mentioned this pull request Jun 16, 2026
Closed
@kubestellar-hive kubestellar-hive Bot mentioned this pull request Jun 16, 2026
Open
@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Post-merge build verification passed ✅

Both Go and frontend builds compiled successfully against merge commit 2da7bf424f7ad7971740de77239532d5f733b563.

@clubanderson clubanderson mentioned this pull request Jun 16, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

ai-generated Pull request generated by AI dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tier/2-standard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Auto-QA] Refresh icon animation consistency issues [Auto-QA] Inconsistent spacing values in styles

2 participants

@clubanderson