Skip to content

fix: stale Helm release history after successful rollback#18799

Merged
clubanderson merged 2 commits into
kubestellar:mainfrom
ashnaaseth2325-oss:fix/helm-drilldown-history-refresh-after-rollback
Jun 19, 2026
Merged

fix: stale Helm release history after successful rollback#18799
clubanderson merged 2 commits into
kubestellar:mainfrom
ashnaaseth2325-oss:fix/helm-drilldown-history-refresh-after-rollback

Conversation

@ashnaaseth2325-oss

Copy link
Copy Markdown
Contributor

SUMMARY

This PR fixes an issue in the Helm Release drilldown where the History tab continued to display stale revision data after a successful rollback. The change updates the history refresh logic in HelmReleaseDrillDown.tsx to ensure fresh revision data is fetched when a rollback completes, while preserving the existing caching behavior for normal tab navigation.

FIX

//After
const fetchHistory = async (force = false) => {
  if (!agentConnected || (releaseHistory && !force)) return
  ...
}

if (result.success) {
  fetchReleaseInfo()
  fetchHistory(true)
}

Copilot AI review requested due to automatic review settings June 17, 2026 18:53
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Jun 17, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mikespreitzer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify

netlify Bot commented Jun 17, 2026

Copy link
Copy Markdown

Deploy Preview for kubestellarconsole ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 05c0eb9
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6a355bb8cc21490008713f37
😎 Deploy Preview https://deploy-preview-18799.console-deploy-preview.kubestellar.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 17, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR updates the Helm release drilldown to allow the release history to be re-fetched after a rollback, instead of being skipped once cached.

Changes:

  • Added a force parameter to fetchHistory to bypass the releaseHistory cache guard when needed.
  • Updated the rollback success path to call fetchHistory(true) to refresh history.

Comment thread web/src/components/drilldown/views/HelmReleaseDrillDown.tsx
Comment thread web/src/components/drilldown/views/HelmReleaseDrillDown.tsx
@kubestellar-prow kubestellar-prow Bot added dco-signoff: no Indicates the PR's author has not signed the DCO. and removed dco-signoff: yes Indicates the PR's author has signed the DCO. labels Jun 17, 2026
@ashnaaseth2325-oss ashnaaseth2325-oss force-pushed the fix/helm-drilldown-history-refresh-after-rollback branch from f7f239e to c5380eb Compare June 17, 2026 19:58
@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. and removed dco-signoff: no Indicates the PR's author has not signed the DCO. labels Jun 17, 2026
@clubanderson

Copy link
Copy Markdown
Collaborator

Scanner note: This PR is from an external contributor (fork), so CI checks (PR Verifier, Build and Deploy) are skipped due to the fork security guard (if: github.event.pull_request.head.repo.full_name == github.repository).

A maintainer should review the changes manually and either:

  1. Cherry-pick to an internal branch for CI verification, or
  2. Approve and merge after manual review

@clubanderson

Copy link
Copy Markdown
Collaborator

🔍 Scanner pass — This PR's build-gate failure is caused by a pre-existing compilation error on main (pkg/api/audit/webhook_send_test.go:200: undefined: store). A systemic fix PR has been opened to resolve this. Once that merges and this PR's branch is updated, CI should pass.

The code change itself (adding force parameter to fetchHistory) looks correct.

Signed-off-by: ashnaaseth2325-oss <ashnaaseth2325@gmail.com>
Signed-off-by: ashnaaseth2325-oss <ashnaaseth2325@gmail.com>
@clubanderson clubanderson force-pushed the fix/helm-drilldown-history-refresh-after-rollback branch from c5380eb to 05c0eb9 Compare June 19, 2026 15:09
@clubanderson clubanderson merged commit 81fcf9e into kubestellar:main Jun 19, 2026
33 of 40 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

✅ Post-Merge Verification: passed

Commit: 81fcf9ec163b1c0d3cc10693225d56adc2a88fa9
Specs run: DrillDown.spec.ts smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/27834147168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants