[scanner] 🐛 fix: remove duplicate test and unused import blocking nightly release#19248
Conversation
Remove duplicate TestMissions_ShareToSlack_EmptyText (already defined in share_error_test.go) and unused fiber/v2 import that cause compilation failures blocking the nightly release. Partial fix for #18426 Signed-off-by: KubeStellar Scanner <scanner@kubestellar.io> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
✅ Deploy Preview for kubestellarconsole canceled.
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
👋 Hey @clubanderson — thanks for opening this PR!
This is an automated message. |
|
🐝 Hi @clubanderson! I'm Trusted users — org members and contributors with write access — can mention Automation may take a moment to start, and follow-up happens through workflow activity rather than chat replies. |
There was a problem hiding this comment.
Pull request overview
This PR removes Go test compilation blockers in pkg/api/handlers/missions by eliminating a duplicate test function and an unused import, unblocking the missions test package so the nightly release pipeline can proceed.
Changes:
- Removed the duplicate
TestMissions_ShareToSlack_EmptyTextfromshare_test.go(confirmed it already exists inshare_error_test.go). - Removed an unused
github.com/gofiber/fiber/v2import fromshare_test.go.
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
|
Post-merge build verification passed ✅ Both Go and frontend builds compiled successfully against merge commit |
✅ Post-Merge Verification: passedCommit: |
Fixes #18426
Partial fix addressing compilation errors in
pkg/api/handlers/missions/that block the nightly release:Changes:
TestMissions_ShareToSlack_EmptyTextfunction fromshare_test.go(already defined inshare_error_test.go— Go disallows duplicate function names in the same package)"github.com/gofiber/fiber/v2"import fromshare_test.goThese two issues cause the entire missions test package to fail compilation, which cascades to fail:
TestMissions_BrowseConsoleKB_EmbeddedFallbackTestMissions_GetMissionFile_EmbeddedFallbackTestGetKBScores_UpstreamErrorRemaining nightly failures (separate root causes, tracked in #18426 comments):
pkg/k8s/gpu— requires architectural decision