Skip to content

[scanner] 🐛 fix: remove duplicate test and unused import blocking nightly release#19248

Merged
clubanderson merged 1 commit into
mainfrom
scanner/fix-18426-missions
Jun 20, 2026
Merged

[scanner] 🐛 fix: remove duplicate test and unused import blocking nightly release#19248
clubanderson merged 1 commit into
mainfrom
scanner/fix-18426-missions

Conversation

@clubanderson

Copy link
Copy Markdown
Collaborator

Fixes #18426

Partial fix addressing compilation errors in pkg/api/handlers/missions/ that block the nightly release:

Changes:

  • Remove duplicate TestMissions_ShareToSlack_EmptyText function from share_test.go (already defined in share_error_test.go — Go disallows duplicate function names in the same package)
  • Remove unused "github.com/gofiber/fiber/v2" import from share_test.go

These two issues cause the entire missions test package to fail compilation, which cascades to fail:

  • TestMissions_BrowseConsoleKB_EmbeddedFallback
  • TestMissions_GetMissionFile_EmbeddedFallback
  • TestGetKBScores_UpstreamError

Remaining nightly failures (separate root causes, tracked in #18426 comments):

  • AI provider tests (Claude, Codex, Gemini) — separate package
  • KC-Agent URL normalization — separate package
  • Import cycle in pkg/k8s/gpu — requires architectural decision

Remove duplicate TestMissions_ShareToSlack_EmptyText (already defined in
share_error_test.go) and unused fiber/v2 import that cause compilation
failures blocking the nightly release.

Partial fix for #18426

Signed-off-by: KubeStellar Scanner <scanner@kubestellar.io>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 20, 2026 02:25
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Jun 20, 2026
@netlify

netlify Bot commented Jun 20, 2026

Copy link
Copy Markdown

Deploy Preview for kubestellarconsole canceled.

Name Link
🔨 Latest commit 08337ec
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6a35fa3784e43f000822e9a7

@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mikespreitzer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

Copy link
Copy Markdown
Contributor

👋 Hey @clubanderson — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.


This is an automated message.

@github-actions

Copy link
Copy Markdown
Contributor

🐝 Hi @clubanderson! I'm kubestellar-hive[bot], an automation bot for this repo.

Trusted users — org members and contributors with write access — can mention @kubestellar-hive in a comment to trigger repo automation.
On issues, that mention queues an automated fix attempt. On pull requests, it records extra context for existing automation.
This is not an interactive Q&A bot, so mentions should be treated as requests for automation rather than a conversation.

Automation may take a moment to start, and follow-up happens through workflow activity rather than chat replies.

@github-actions github-actions Bot added the ai-generated Pull request generated by AI label Jun 20, 2026
@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 20, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes Go test compilation blockers in pkg/api/handlers/missions by eliminating a duplicate test function and an unused import, unblocking the missions test package so the nightly release pipeline can proceed.

Changes:

  • Removed the duplicate TestMissions_ShareToSlack_EmptyText from share_test.go (confirmed it already exists in share_error_test.go).
  • Removed an unused github.com/gofiber/fiber/v2 import from share_test.go.

@clubanderson clubanderson merged commit a5bb6cd into main Jun 20, 2026
37 of 43 checks passed
@kubestellar-prow kubestellar-prow Bot deleted the scanner/fix-18426-missions branch June 20, 2026 02:43
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

@github-actions

Copy link
Copy Markdown
Contributor

Post-merge build verification passed

Both Go and frontend builds compiled successfully against merge commit a5bb6cd00100de805d47c799946a0c3c573056d0.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Post-Merge Verification: passed

Commit: a5bb6cd00100de805d47c799946a0c3c573056d0
Specs run: smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/27857813783

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated Pull request generated by AI dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tier/1-lightweight

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🚨 nightly release failing

2 participants