[scanner] fix: replace inconsistent spacing values with Tailwind utilities#19282
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for kubestellarconsole canceled.
|
|
👋 Hey @clubanderson — thanks for opening this PR!
This is an automated message. |
|
🐝 Hi @clubanderson! I'm Trusted users — org members and contributors with write access — can mention Automation may take a moment to start, and follow-up happens through workflow activity rather than chat replies. |
✅ Test Coverage CheckAll new source files in this PR have corresponding test files. Checked |
Auto Test GeneratorThe following new files have no corresponding test file:
Please add tests or apply the |
There was a problem hiding this comment.
Pull request overview
This PR aims to standardize UI sizing by replacing inline px spacing/font/animation values with rem-based equivalents aligned with Tailwind’s sizing scale, reducing “non-standard spacing” warnings and improving consistency across components.
Changes:
- Convert several inline style sizing values from
pxtoremequivalents (spacing, font sizes, border radius). - Update animation positioning values in the LLM-d configurator toggle to use
remunits. - Apply similar sizing conversions in chart-related tooltip/test styling.
Note: build/lint are validated by CI on the PR (per repo guidance).
Reviewed changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| web/src/components/widgets/widget-export-modal/WidgetExportModalPreview.tsx | Replace inline px spacing/font constants with rem equivalents for consistent sizing. |
| web/src/lib/auth.tsx | Convert DOM banner spacing/font sizing constants to rem-aligned values. |
| web/src/components/cards/llmd/LLMdConfigurator.tsx | Update Framer Motion toggle knob positioning from px to rem scale. |
| web/src/components/cards/IssueActivityChart.tsx | Standardize tooltip marker sizing away from px literals to rem equivalents. |
| web/src/lib/unified/card/visualizations/tests/ChartVisualization.test.tsx | Update test styling (e.g., border radius) to rem scale for consistency. |
| <motion.div | ||
| className="absolute top-0.5 w-4 h-4 bg-white dark:bg-gray-200 rounded-full" | ||
| animate={{ left: param.value ? '22px' : '2px' }} | ||
| animate={{ left: param.value ? '1.375rem' : '0.125rem' }} | ||
| /> |
Signed-off-by: clubanderson <clubanderson@users.noreply.github.com>
|
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
✅ Post-Merge Verification: passedCommit: |
|
Post-merge build verification passed ✅ Both Go and frontend builds compiled successfully against merge commit |
Fixes #19271
Summary
This PR replaces non-standard inline px spacing values with rem-based equivalents aligned to Tailwind CSS conventions.
Changed Files
web/src/components/widgets/widget-export-modal/WidgetExportModalPreview.tsx: Converted 19 spacing/font size constants from px to remweb/src/lib/auth.tsx: Converted banner padding, gap, margin, and font sizes from px to remweb/src/components/cards/llmd/LLMdConfigurator.tsx: Updated animation values from px to remweb/src/components/cards/IssueActivityChart.tsx: Changed tooltip dot from 10px to 0.625remweb/src/lib/unified/card/visualizations/__tests__/ChartVisualization.test.tsx: Changed borderRadius from 6px to 0.375remConversion Scale Used