Skip to content

[scanner] fix: replace inconsistent spacing values with Tailwind utilities#19282

Merged
clubanderson merged 3 commits into
mainfrom
scanner/fix-19271
Jun 20, 2026
Merged

[scanner] fix: replace inconsistent spacing values with Tailwind utilities#19282
clubanderson merged 3 commits into
mainfrom
scanner/fix-19271

Conversation

@clubanderson

Copy link
Copy Markdown
Collaborator

Fixes #19271

Summary

This PR replaces non-standard inline px spacing values with rem-based equivalents aligned to Tailwind CSS conventions.

Changed Files

  • web/src/components/widgets/widget-export-modal/WidgetExportModalPreview.tsx: Converted 19 spacing/font size constants from px to rem
  • web/src/lib/auth.tsx: Converted banner padding, gap, margin, and font sizes from px to rem
  • web/src/components/cards/llmd/LLMdConfigurator.tsx: Updated animation values from px to rem
  • web/src/components/cards/IssueActivityChart.tsx: Changed tooltip dot from 10px to 0.625rem
  • web/src/lib/unified/card/visualizations/__tests__/ChartVisualization.test.tsx: Changed borderRadius from 6px to 0.375rem

Conversion Scale Used

  • 2px → 0.125rem
  • 4px → 0.25rem
  • 6px → 0.375rem
  • 10px → 0.625rem
  • 12px → 0.75rem
  • 14px → 0.875rem
  • 22px → 1.375rem
  • 24px → 1.5rem

Copilot AI review requested due to automatic review settings June 20, 2026 09:23
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: no Indicates the PR's author has not signed the DCO. label Jun 20, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify

netlify Bot commented Jun 20, 2026

Copy link
Copy Markdown

Deploy Preview for kubestellarconsole canceled.

Name Link
🔨 Latest commit 1625368
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6a36611caee88f0008a96c87

@github-actions

Copy link
Copy Markdown
Contributor

👋 Hey @clubanderson — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.


This is an automated message.

@github-actions

Copy link
Copy Markdown
Contributor

🐝 Hi @clubanderson! I'm kubestellar-hive[bot], an automation bot for this repo.

Trusted users — org members and contributors with write access — can mention @kubestellar-hive in a comment to trigger repo automation.
On issues, that mention queues an automated fix attempt. On pull requests, it records extra context for existing automation.
This is not an interactive Q&A bot, so mentions should be treated as requests for automation rather than a conversation.

Automation may take a moment to start, and follow-up happens through workflow activity rather than chat replies.

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

✅ Test Coverage Check

All new source files in this PR have corresponding test files.

Checked web/src/hooks/ and web/src/components/ against origin/main.

@github-actions

Copy link
Copy Markdown
Contributor

Auto Test Generator

The following new files have no corresponding test file:

  • web/src/components/cards/llmd/LLMdConfigurator.tsx

Please add tests or apply the needs-tests label to track this PR.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to standardize UI sizing by replacing inline px spacing/font/animation values with rem-based equivalents aligned with Tailwind’s sizing scale, reducing “non-standard spacing” warnings and improving consistency across components.

Changes:

  • Convert several inline style sizing values from px to rem equivalents (spacing, font sizes, border radius).
  • Update animation positioning values in the LLM-d configurator toggle to use rem units.
  • Apply similar sizing conversions in chart-related tooltip/test styling.

Note: build/lint are validated by CI on the PR (per repo guidance).

Reviewed changes

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
web/src/components/widgets/widget-export-modal/WidgetExportModalPreview.tsx Replace inline px spacing/font constants with rem equivalents for consistent sizing.
web/src/lib/auth.tsx Convert DOM banner spacing/font sizing constants to rem-aligned values.
web/src/components/cards/llmd/LLMdConfigurator.tsx Update Framer Motion toggle knob positioning from px to rem scale.
web/src/components/cards/IssueActivityChart.tsx Standardize tooltip marker sizing away from px literals to rem equivalents.
web/src/lib/unified/card/visualizations/tests/ChartVisualization.test.tsx Update test styling (e.g., border radius) to rem scale for consistency.

Comment on lines 105 to 108
<motion.div
className="absolute top-0.5 w-4 h-4 bg-white dark:bg-gray-200 rounded-full"
animate={{ left: param.value ? '22px' : '2px' }}
animate={{ left: param.value ? '1.375rem' : '0.125rem' }}
/>
clubanderson and others added 2 commits June 20, 2026 05:41
Signed-off-by: clubanderson <clubanderson@users.noreply.github.com>
@kubestellar-prow

Copy link
Copy Markdown
Contributor

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • 00effae 🌱 fix: replace px with rem in LLMdConfigurator
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@clubanderson clubanderson merged commit 6225cf6 into main Jun 20, 2026
36 of 44 checks passed
@kubestellar-prow kubestellar-prow Bot deleted the scanner/fix-19271 branch June 20, 2026 11:18
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

@github-actions

Copy link
Copy Markdown
Contributor

✅ Post-Merge Verification: passed

Commit: 6225cf6649e6cc697c42a972d8cdf48130a5b633
Specs run: Dashboard.spec.ts smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/27869562491

@github-actions

Copy link
Copy Markdown
Contributor

Post-merge build verification passed

Both Go and frontend builds compiled successfully against merge commit 6225cf6649e6cc697c42a972d8cdf48130a5b633.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: no Indicates the PR's author has not signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tier/2-standard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Auto-QA] Inconsistent spacing values in styles

2 participants