[scanner] 🌱 split analytics-events.test.ts (1546 lines) into focused modules#19322
Merged
Conversation
…used modules Split the oversized analytics-events.test.ts test file into 3 focused modules: - analytics-events.cards-interactions.test.ts (684 lines) - Dashboard, cards, search, and UI interactions - analytics-events.system-operations.test.ts (639 lines) - Auth, settings, APIs, and cluster operations - analytics-events.engagement-lifecycle.test.ts (668 lines) - Nudges, recommendations, features, and ACMM This addresses issue #18598 by reducing one of the largest oversized test files. Each new file contains logically grouped test suites with proper structure and closure. Signed-off-by: hive-scanner <scanner@kubestellar.io> Signed-off-by: Hive Scanner <hive-scanner@kubestellar.local>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubestellar-prow
Bot
added
the
dco-signoff: yes
✅ Deploy Preview for kubestellarconsole ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
👋 Hey @clubanderson — thanks for opening this PR!
This is an automated message. |
kubestellar-prow
Bot
added
the
size/XXL
Contributor
|
🐝 Hi @clubanderson! I'm Trusted users — org members and contributors with write access — can mention Automation may take a moment to start, and follow-up happens through workflow activity rather than chat replies. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the analytics emitter test coverage by removing the monolithic web/src/lib/__tests__/analytics-events.test.ts and replacing it with three separate Vitest modules intended to be organized by logical event groupings (per #18598’s “oversized files” initiative).
Changes:
- Deleted the 1546-line
analytics-events.test.ts. - Added
analytics-events.cards-interactions.test.ts,analytics-events.system-operations.test.ts, andanalytics-events.engagement-lifecycle.test.tsto distribute the suites across multiple files. - Replicated the shared mocking/setup boilerplate into each new module.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| web/src/lib/tests/analytics-events.test.ts | Removed the original monolithic analytics-events emitter test file. |
| web/src/lib/tests/analytics-events.cards-interactions.test.ts | Added one of the split test modules; currently contains a syntax/braces issue at EOF and includes suites beyond “cards interactions”. |
| web/src/lib/tests/analytics-events.system-operations.test.ts | Added one of the split test modules covering operational/system-related emitters and flows. |
| web/src/lib/tests/analytics-events.engagement-lifecycle.test.ts | Added one of the split test modules covering engagement/lifecycle-related emitters and flows. |
| import { send, setAnalyticsUserProperties, emitError } from '../analytics-core' | ||
| import { isDemoMode } from '../demoMode' | ||
| import { getDeploymentType } from '../analytics-session' | ||
| import { CAPABILITY_TOOL_EXEC, CAPABILITY_CHAT } from '../analytics-types' |
| import { send, setAnalyticsUserProperties, emitError } from '../analytics-core' | ||
| import { isDemoMode } from '../demoMode' | ||
| import { getDeploymentType } from '../analytics-session' | ||
| import { CAPABILITY_TOOL_EXEC, CAPABILITY_CHAT } from '../analytics-types' |
Comment on lines
+1
to
+6
| /** | ||
| * Tests for analytics-events.ts emit functions. | ||
| * | ||
| * We mock the `send` function from analytics-core and verify that each | ||
| * emitter calls it with the correct event name and parameters. | ||
| */ |
Comment on lines
+469
to
+481
| describe('Auth', () => { | ||
| it('emitLogin sends method', () => { | ||
| emitLogin('github') | ||
| expect(mockSend).toHaveBeenCalledWith('login', { method: 'github' }) | ||
| }) | ||
|
|
||
| it('emitLogout sends event', () => { | ||
| emitLogout() | ||
| expect(mockSend).toHaveBeenCalledWith('ksc_logout') | ||
| }) | ||
| }) | ||
|
|
||
| describe('Feedback', () => { |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Comment on lines
+27
to
+203
| import { | ||
| emitCardAdded, | ||
| emitCardRemoved, | ||
| emitCardExpanded, | ||
| emitCardDragged, | ||
| emitCardConfigured, | ||
| emitCardReplaced, | ||
| emitGlobalSearchOpened, | ||
| emitGlobalSearchQueried, | ||
| emitGlobalSearchSelected, | ||
| emitGlobalSearchAskAI, | ||
| emitCardSortChanged, | ||
| emitCardSortDirectionChanged, | ||
| emitCardLimitChanged, | ||
| emitCardSearchUsed, | ||
| emitCardClusterFilterChanged, | ||
| emitCardPaginationUsed, | ||
| emitCardListItemClicked, | ||
| emitMissionStarted, | ||
| emitMissionCompleted, | ||
| emitMissionError, | ||
| emitMissionRated, | ||
| emitFixerSearchStarted, | ||
| emitFixerSearchCompleted, | ||
| emitFixerBrowsed, | ||
| emitFixerViewed, | ||
| emitFixerImported, | ||
| emitFixerImportError, | ||
| emitFixerLinkCopied, | ||
| emitFixerGitHubLink, | ||
| emitLogin, | ||
| emitLogout, | ||
| emitFeedbackSubmitted, | ||
| emitScreenshotAttached, | ||
| emitScreenshotUploadFailed, | ||
| emitScreenshotUploadSuccess, | ||
| emitNPSSurveyShown, | ||
| emitNPSResponse, | ||
| emitNPSDismissed, | ||
| emitOrbitMissionCreated, | ||
| emitOrbitMissionRun, | ||
| emitGroundControlDashboardCreated, | ||
| emitGroundControlCardRequestOpened, | ||
| emitSessionExpired, | ||
| emitTourStarted, | ||
| emitTourCompleted, | ||
| emitTourSkipped, | ||
| emitMarketplaceInstall, | ||
| emitMarketplaceRemove, | ||
| emitMarketplaceInstallFailed, | ||
| emitThemeChanged, | ||
| emitLanguageChanged, | ||
| emitAIModeChanged, | ||
| emitAIPredictionsToggled, | ||
| emitConfidenceThresholdChanged, | ||
| emitConsensusModeToggled, | ||
| emitGitHubTokenConfigured, | ||
| emitGitHubTokenRemoved, | ||
| emitApiProviderConnected, | ||
| emitDemoModeToggled, | ||
| emitAgentTokenFailure, | ||
| emitWsAuthMissing, | ||
| emitSseAuthFailure, | ||
| emitSessionRefreshFailure, | ||
| emitAgentConnected, | ||
| emitAgentDisconnected, | ||
| emitClusterInventory, | ||
| emitAgentProvidersDetected, | ||
| emitApiKeyConfigured, | ||
| emitApiKeyRemoved, | ||
| emitInstallCommandCopied, | ||
| emitConversionStep, | ||
| emitDeployWorkload, | ||
| emitDeployTemplateApplied, | ||
| emitComplianceDrillDown, | ||
| emitComplianceFilterChanged, | ||
| emitBenchmarkViewed, | ||
| emitClusterCreated, | ||
| emitGitHubConnected, | ||
| emitClusterAction, | ||
| emitClusterStatsDrillDown, | ||
| emitWidgetLoaded, | ||
| emitWidgetNavigation, | ||
| emitWidgetInstalled, | ||
| emitWidgetDownloaded, | ||
| emitNudgeShown, | ||
| emitNudgeDismissed, | ||
| emitNudgeActioned, | ||
| emitSmartSuggestionsShown, | ||
| emitSmartSuggestionAccepted, | ||
| emitSmartSuggestionsAddAll, | ||
| emitCardRecommendationsShown, | ||
| emitCardRecommendationActioned, | ||
| emitMissionSuggestionsShown, | ||
| emitMissionSuggestionActioned, | ||
| emitAddCardModalOpened, | ||
| emitAddCardModalAbandoned, | ||
| emitDashboardScrolled, | ||
| emitPwaPromptShown, | ||
| emitPwaPromptDismissed, | ||
| emitLinkedInShare, | ||
| emitSessionContext, | ||
| emitUpdateChecked, | ||
| emitUpdateTriggered, | ||
| emitUpdateCompleted, | ||
| emitUpdateFailed, | ||
| emitUpdateRefreshed, | ||
| emitUpdateStalled, | ||
| emitDrillDownOpened, | ||
| emitDrillDownClosed, | ||
| emitCardRefreshed, | ||
| emitGlobalClusterFilterChanged, | ||
| emitGlobalSeverityFilterChanged, | ||
| emitGlobalStatusFilterChanged, | ||
| emitPredictionFeedbackSubmitted, | ||
| emitSnoozed, | ||
| emitUnsnoozed, | ||
| emitDashboardCreated, | ||
| emitDashboardDeleted, | ||
| emitDashboardRenamed, | ||
| emitDashboardImported, | ||
| emitDashboardExported, | ||
| emitDataExported, | ||
| emitUserRoleChanged, | ||
| emitUserRemoved, | ||
| emitMarketplaceItemViewed, | ||
| emitInsightViewed, | ||
| emitGameStarted, | ||
| emitGameEnded, | ||
| emitSidebarNavigated, | ||
| emitLocalClusterCreated, | ||
| emitDeveloperSession, | ||
| emitCardCategoryBrowsed, | ||
| emitRecommendedCardShown, | ||
| emitDashboardViewed, | ||
| emitFeatureHintShown, | ||
| emitFeatureHintDismissed, | ||
| emitFeatureHintActioned, | ||
| emitGettingStartedShown, | ||
| emitGettingStartedActioned, | ||
| emitPostConnectShown, | ||
| emitPostConnectActioned, | ||
| emitDemoToLocalShown, | ||
| emitDemoToLocalActioned, | ||
| emitAdopterNudgeShown, | ||
| emitAdopterNudgeActioned, | ||
| emitModalOpened, | ||
| emitModalTabViewed, | ||
| emitModalClosed, | ||
| emitInsightAcknowledged, | ||
| emitInsightDismissed, | ||
| emitActionClicked, | ||
| emitAISuggestionViewed, | ||
| emitWelcomeViewed, | ||
| emitWelcomeActioned, | ||
| emitFromLensViewed, | ||
| emitFromLensActioned, | ||
| emitFromLensTabSwitch, | ||
| emitFromLensCommandCopy, | ||
| emitFromHeadlampViewed, | ||
| emitFromHeadlampActioned, | ||
| emitFromHeadlampTabSwitch, | ||
| emitFromHeadlampCommandCopy, | ||
| emitWhiteLabelViewed, | ||
| emitWhiteLabelActioned, | ||
| emitWhiteLabelTabSwitch, | ||
| emitWhiteLabelCommandCopy, | ||
| emitTipShown, | ||
| emitStreakDay, | ||
| emitBlogPostClicked, | ||
| emitWhatsNewModalOpened, | ||
| emitWhatsNewUpdateClicked, | ||
| emitWhatsNewRemindLater, | ||
| emitACMMScanned, | ||
| emitACMMMissionLaunched, | ||
| emitACMMLevelMissionLaunched, | ||
| } from '../analytics-events' |
| import { send, setAnalyticsUserProperties, emitError } from '../analytics-core' | ||
| import { isDemoMode } from '../demoMode' | ||
| import { getDeploymentType } from '../analytics-session' | ||
| import { CAPABILITY_TOOL_EXEC, CAPABILITY_CHAT } from '../analytics-types' |
Comment on lines
+27
to
+203
| import { | ||
| emitCardAdded, | ||
| emitCardRemoved, | ||
| emitCardExpanded, | ||
| emitCardDragged, | ||
| emitCardConfigured, | ||
| emitCardReplaced, | ||
| emitGlobalSearchOpened, | ||
| emitGlobalSearchQueried, | ||
| emitGlobalSearchSelected, | ||
| emitGlobalSearchAskAI, | ||
| emitCardSortChanged, | ||
| emitCardSortDirectionChanged, | ||
| emitCardLimitChanged, | ||
| emitCardSearchUsed, | ||
| emitCardClusterFilterChanged, | ||
| emitCardPaginationUsed, | ||
| emitCardListItemClicked, | ||
| emitMissionStarted, | ||
| emitMissionCompleted, | ||
| emitMissionError, | ||
| emitMissionRated, | ||
| emitFixerSearchStarted, | ||
| emitFixerSearchCompleted, | ||
| emitFixerBrowsed, | ||
| emitFixerViewed, | ||
| emitFixerImported, | ||
| emitFixerImportError, | ||
| emitFixerLinkCopied, | ||
| emitFixerGitHubLink, | ||
| emitLogin, | ||
| emitLogout, | ||
| emitFeedbackSubmitted, | ||
| emitScreenshotAttached, | ||
| emitScreenshotUploadFailed, | ||
| emitScreenshotUploadSuccess, | ||
| emitNPSSurveyShown, | ||
| emitNPSResponse, | ||
| emitNPSDismissed, | ||
| emitOrbitMissionCreated, | ||
| emitOrbitMissionRun, | ||
| emitGroundControlDashboardCreated, | ||
| emitGroundControlCardRequestOpened, | ||
| emitSessionExpired, | ||
| emitTourStarted, | ||
| emitTourCompleted, | ||
| emitTourSkipped, | ||
| emitMarketplaceInstall, | ||
| emitMarketplaceRemove, | ||
| emitMarketplaceInstallFailed, | ||
| emitThemeChanged, | ||
| emitLanguageChanged, | ||
| emitAIModeChanged, | ||
| emitAIPredictionsToggled, | ||
| emitConfidenceThresholdChanged, | ||
| emitConsensusModeToggled, | ||
| emitGitHubTokenConfigured, | ||
| emitGitHubTokenRemoved, | ||
| emitApiProviderConnected, | ||
| emitDemoModeToggled, | ||
| emitAgentTokenFailure, | ||
| emitWsAuthMissing, | ||
| emitSseAuthFailure, | ||
| emitSessionRefreshFailure, | ||
| emitAgentConnected, | ||
| emitAgentDisconnected, | ||
| emitClusterInventory, | ||
| emitAgentProvidersDetected, | ||
| emitApiKeyConfigured, | ||
| emitApiKeyRemoved, | ||
| emitInstallCommandCopied, | ||
| emitConversionStep, | ||
| emitDeployWorkload, | ||
| emitDeployTemplateApplied, | ||
| emitComplianceDrillDown, | ||
| emitComplianceFilterChanged, | ||
| emitBenchmarkViewed, | ||
| emitClusterCreated, | ||
| emitGitHubConnected, | ||
| emitClusterAction, | ||
| emitClusterStatsDrillDown, | ||
| emitWidgetLoaded, | ||
| emitWidgetNavigation, | ||
| emitWidgetInstalled, | ||
| emitWidgetDownloaded, | ||
| emitNudgeShown, | ||
| emitNudgeDismissed, | ||
| emitNudgeActioned, | ||
| emitSmartSuggestionsShown, | ||
| emitSmartSuggestionAccepted, | ||
| emitSmartSuggestionsAddAll, | ||
| emitCardRecommendationsShown, | ||
| emitCardRecommendationActioned, | ||
| emitMissionSuggestionsShown, | ||
| emitMissionSuggestionActioned, | ||
| emitAddCardModalOpened, | ||
| emitAddCardModalAbandoned, | ||
| emitDashboardScrolled, | ||
| emitPwaPromptShown, | ||
| emitPwaPromptDismissed, | ||
| emitLinkedInShare, | ||
| emitSessionContext, | ||
| emitUpdateChecked, | ||
| emitUpdateTriggered, | ||
| emitUpdateCompleted, | ||
| emitUpdateFailed, | ||
| emitUpdateRefreshed, | ||
| emitUpdateStalled, | ||
| emitDrillDownOpened, | ||
| emitDrillDownClosed, | ||
| emitCardRefreshed, | ||
| emitGlobalClusterFilterChanged, | ||
| emitGlobalSeverityFilterChanged, | ||
| emitGlobalStatusFilterChanged, | ||
| emitPredictionFeedbackSubmitted, | ||
| emitSnoozed, | ||
| emitUnsnoozed, | ||
| emitDashboardCreated, | ||
| emitDashboardDeleted, | ||
| emitDashboardRenamed, | ||
| emitDashboardImported, | ||
| emitDashboardExported, | ||
| emitDataExported, | ||
| emitUserRoleChanged, | ||
| emitUserRemoved, | ||
| emitMarketplaceItemViewed, | ||
| emitInsightViewed, | ||
| emitGameStarted, | ||
| emitGameEnded, | ||
| emitSidebarNavigated, | ||
| emitLocalClusterCreated, | ||
| emitDeveloperSession, | ||
| emitCardCategoryBrowsed, | ||
| emitRecommendedCardShown, | ||
| emitDashboardViewed, | ||
| emitFeatureHintShown, | ||
| emitFeatureHintDismissed, | ||
| emitFeatureHintActioned, | ||
| emitGettingStartedShown, | ||
| emitGettingStartedActioned, | ||
| emitPostConnectShown, | ||
| emitPostConnectActioned, | ||
| emitDemoToLocalShown, | ||
| emitDemoToLocalActioned, | ||
| emitAdopterNudgeShown, | ||
| emitAdopterNudgeActioned, | ||
| emitModalOpened, | ||
| emitModalTabViewed, | ||
| emitModalClosed, | ||
| emitInsightAcknowledged, | ||
| emitInsightDismissed, | ||
| emitActionClicked, | ||
| emitAISuggestionViewed, | ||
| emitWelcomeViewed, | ||
| emitWelcomeActioned, | ||
| emitFromLensViewed, | ||
| emitFromLensActioned, | ||
| emitFromLensTabSwitch, | ||
| emitFromLensCommandCopy, | ||
| emitFromHeadlampViewed, | ||
| emitFromHeadlampActioned, | ||
| emitFromHeadlampTabSwitch, | ||
| emitFromHeadlampCommandCopy, | ||
| emitWhiteLabelViewed, | ||
| emitWhiteLabelActioned, | ||
| emitWhiteLabelTabSwitch, | ||
| emitWhiteLabelCommandCopy, | ||
| emitTipShown, | ||
| emitStreakDay, | ||
| emitBlogPostClicked, | ||
| emitWhatsNewModalOpened, | ||
| emitWhatsNewUpdateClicked, | ||
| emitWhatsNewRemindLater, | ||
| emitACMMScanned, | ||
| emitACMMMissionLaunched, | ||
| emitACMMLevelMissionLaunched, | ||
| } from '../analytics-events' |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Hive Scanner <hive-scanner@kubestellar.local>
| import { send, setAnalyticsUserProperties, emitError } from '../analytics-core' | ||
| import { isDemoMode } from '../demoMode' | ||
| import { getDeploymentType } from '../analytics-session' | ||
| import { CAPABILITY_TOOL_EXEC, CAPABILITY_CHAT } from '../analytics-types' |
Comment on lines
+27
to
+203
| import { | ||
| emitCardAdded, | ||
| emitCardRemoved, | ||
| emitCardExpanded, | ||
| emitCardDragged, | ||
| emitCardConfigured, | ||
| emitCardReplaced, | ||
| emitGlobalSearchOpened, | ||
| emitGlobalSearchQueried, | ||
| emitGlobalSearchSelected, | ||
| emitGlobalSearchAskAI, | ||
| emitCardSortChanged, | ||
| emitCardSortDirectionChanged, | ||
| emitCardLimitChanged, | ||
| emitCardSearchUsed, | ||
| emitCardClusterFilterChanged, | ||
| emitCardPaginationUsed, | ||
| emitCardListItemClicked, | ||
| emitMissionStarted, | ||
| emitMissionCompleted, | ||
| emitMissionError, | ||
| emitMissionRated, | ||
| emitFixerSearchStarted, | ||
| emitFixerSearchCompleted, | ||
| emitFixerBrowsed, | ||
| emitFixerViewed, | ||
| emitFixerImported, | ||
| emitFixerImportError, | ||
| emitFixerLinkCopied, | ||
| emitFixerGitHubLink, | ||
| emitLogin, | ||
| emitLogout, | ||
| emitFeedbackSubmitted, | ||
| emitScreenshotAttached, | ||
| emitScreenshotUploadFailed, | ||
| emitScreenshotUploadSuccess, | ||
| emitNPSSurveyShown, | ||
| emitNPSResponse, | ||
| emitNPSDismissed, | ||
| emitOrbitMissionCreated, | ||
| emitOrbitMissionRun, | ||
| emitGroundControlDashboardCreated, | ||
| emitGroundControlCardRequestOpened, | ||
| emitSessionExpired, | ||
| emitTourStarted, | ||
| emitTourCompleted, | ||
| emitTourSkipped, | ||
| emitMarketplaceInstall, | ||
| emitMarketplaceRemove, | ||
| emitMarketplaceInstallFailed, | ||
| emitThemeChanged, | ||
| emitLanguageChanged, | ||
| emitAIModeChanged, | ||
| emitAIPredictionsToggled, | ||
| emitConfidenceThresholdChanged, | ||
| emitConsensusModeToggled, | ||
| emitGitHubTokenConfigured, | ||
| emitGitHubTokenRemoved, | ||
| emitApiProviderConnected, | ||
| emitDemoModeToggled, | ||
| emitAgentTokenFailure, | ||
| emitWsAuthMissing, | ||
| emitSseAuthFailure, | ||
| emitSessionRefreshFailure, | ||
| emitAgentConnected, | ||
| emitAgentDisconnected, | ||
| emitClusterInventory, | ||
| emitAgentProvidersDetected, | ||
| emitApiKeyConfigured, | ||
| emitApiKeyRemoved, | ||
| emitInstallCommandCopied, | ||
| emitConversionStep, | ||
| emitDeployWorkload, | ||
| emitDeployTemplateApplied, | ||
| emitComplianceDrillDown, | ||
| emitComplianceFilterChanged, | ||
| emitBenchmarkViewed, | ||
| emitClusterCreated, | ||
| emitGitHubConnected, | ||
| emitClusterAction, | ||
| emitClusterStatsDrillDown, | ||
| emitWidgetLoaded, | ||
| emitWidgetNavigation, | ||
| emitWidgetInstalled, | ||
| emitWidgetDownloaded, | ||
| emitNudgeShown, | ||
| emitNudgeDismissed, | ||
| emitNudgeActioned, | ||
| emitSmartSuggestionsShown, | ||
| emitSmartSuggestionAccepted, | ||
| emitSmartSuggestionsAddAll, | ||
| emitCardRecommendationsShown, | ||
| emitCardRecommendationActioned, | ||
| emitMissionSuggestionsShown, | ||
| emitMissionSuggestionActioned, | ||
| emitAddCardModalOpened, | ||
| emitAddCardModalAbandoned, | ||
| emitDashboardScrolled, | ||
| emitPwaPromptShown, | ||
| emitPwaPromptDismissed, | ||
| emitLinkedInShare, | ||
| emitSessionContext, | ||
| emitUpdateChecked, | ||
| emitUpdateTriggered, | ||
| emitUpdateCompleted, | ||
| emitUpdateFailed, | ||
| emitUpdateRefreshed, | ||
| emitUpdateStalled, | ||
| emitDrillDownOpened, | ||
| emitDrillDownClosed, | ||
| emitCardRefreshed, | ||
| emitGlobalClusterFilterChanged, | ||
| emitGlobalSeverityFilterChanged, | ||
| emitGlobalStatusFilterChanged, | ||
| emitPredictionFeedbackSubmitted, | ||
| emitSnoozed, | ||
| emitUnsnoozed, | ||
| emitDashboardCreated, | ||
| emitDashboardDeleted, | ||
| emitDashboardRenamed, | ||
| emitDashboardImported, | ||
| emitDashboardExported, | ||
| emitDataExported, | ||
| emitUserRoleChanged, | ||
| emitUserRemoved, | ||
| emitMarketplaceItemViewed, | ||
| emitInsightViewed, | ||
| emitGameStarted, | ||
| emitGameEnded, | ||
| emitSidebarNavigated, | ||
| emitLocalClusterCreated, | ||
| emitDeveloperSession, | ||
| emitCardCategoryBrowsed, | ||
| emitRecommendedCardShown, | ||
| emitDashboardViewed, | ||
| emitFeatureHintShown, | ||
| emitFeatureHintDismissed, | ||
| emitFeatureHintActioned, | ||
| emitGettingStartedShown, | ||
| emitGettingStartedActioned, | ||
| emitPostConnectShown, | ||
| emitPostConnectActioned, | ||
| emitDemoToLocalShown, | ||
| emitDemoToLocalActioned, | ||
| emitAdopterNudgeShown, | ||
| emitAdopterNudgeActioned, | ||
| emitModalOpened, | ||
| emitModalTabViewed, | ||
| emitModalClosed, | ||
| emitInsightAcknowledged, | ||
| emitInsightDismissed, | ||
| emitActionClicked, | ||
| emitAISuggestionViewed, | ||
| emitWelcomeViewed, | ||
| emitWelcomeActioned, | ||
| emitFromLensViewed, | ||
| emitFromLensActioned, | ||
| emitFromLensTabSwitch, | ||
| emitFromLensCommandCopy, | ||
| emitFromHeadlampViewed, | ||
| emitFromHeadlampActioned, | ||
| emitFromHeadlampTabSwitch, | ||
| emitFromHeadlampCommandCopy, | ||
| emitWhiteLabelViewed, | ||
| emitWhiteLabelActioned, | ||
| emitWhiteLabelTabSwitch, | ||
| emitWhiteLabelCommandCopy, | ||
| emitTipShown, | ||
| emitStreakDay, | ||
| emitBlogPostClicked, | ||
| emitWhatsNewModalOpened, | ||
| emitWhatsNewUpdateClicked, | ||
| emitWhatsNewRemindLater, | ||
| emitACMMScanned, | ||
| emitACMMMissionLaunched, | ||
| emitACMMLevelMissionLaunched, | ||
| } from '../analytics-events' |
Contributor
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
Contributor
✅ Post-Merge Verification: passedCommit: |
Contributor
|
Post-merge build verification passed ✅ Both Go and frontend builds compiled successfully against merge commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18598
Splits the oversized
analytics-events.test.tstest file (1546 lines) into 3 focused modules based on logical groupings:analytics-events.cards-interactions.test.ts(684 lines) — Dashboard, cards, search, and UI interactionsanalytics-events.system-operations.test.ts(639 lines) — Auth, settings, APIs, and cluster operationsanalytics-events.engagement-lifecycle.test.ts(668 lines) — Nudges, recommendations, features, and ACMMEach new file contains logically grouped test suites with proper structure. This is the first step in addressing the 20+ oversized test files reported in the issue.